Analytics UI Empty States #5121
Conversation
gregfromstl
requested review from
MananTank,
jnsdls and
joaquim-verges
as code owners
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5121 +/- ##
=======================================
Coverage 45.28% 45.28%
=======================================
Files 1060 1060
Lines 54831 54831
Branches 3955 3955
=======================================
Hits 24832 24832
Misses 29308 29308
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more. |
gregfromstl
force-pushed
the
feat/analytics-ui
branch
from
8bafb63 to
3d4c25c
Compare
size-limit report 📦
|
| <EmptyChartState /> | ||
| <EmptyChartState> | ||
| <div className="flex flex-col items-center justify-center"> | ||
| <span className="mb-6 text-lg">Get started with wallets</span> |
There was a problem hiding this comment.
How about "Send your first connect event"
| <EmptyChartState> | ||
| <div className="flex flex-col items-center justify-center"> | ||
| <span className="mb-6 text-lg"> | ||
| Send smart account transactions |
There was a problem hiding this comment.
Same here, "send your first smart account transaction"
| /> | ||
| <DocLink | ||
| link="https://portal.thirdweb.com/typescript/v5/supported-wallets" | ||
| label="React Native" |
There was a problem hiding this comment.
No unity / DotNet / unreal links for this one?
There was a problem hiding this comment.
Didn't see anything that might correspond in their docs since they only have in-app wallets
joaquim-verges
left a comment
joaquim-verges
left a comment
There was a problem hiding this comment.
Great start! Left a couple of comments but feel free to merge and iterate
gregfromstl
force-pushed
the
feat/analytics-ui
branch
from
3d4c25c to
f206f59
Compare
gregfromstl
added
the
merge-queue
Merge activity
|
<img width="968" alt="Screenshot 2024-10-21 at 6 23 23 PM" src="https://github.com/user-attachments/assets/86000f33-2041-4d3a-b084-b6367e61f032"> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on enhancing the `DocLink` component for better link handling and integrating it into various chart components for improved user guidance on wallet connections and transactions. ### Detailed summary - Added `DocLink` component in `DocLink.tsx`. - Refactored `ConnectSDKCard` to use `DocLink` instead of its previous implementation. - Modified `EmptyChartState` to accept `children` for customizable content. - Integrated `DocLink` into multiple chart components, providing links for wallet integration guidance. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
gregfromstl
force-pushed
the
feat/analytics-ui
branch
from
f206f59 to
dd77c7f
Compare
PR-Codex overview
This PR introduces a new component,
DocLink, and replaces inline link implementations with this reusable component across various charts. It also enhances theEmptyChartStatecomponent to accept children, allowing for customizable messages and links.Detailed summary
DocLinkcomponent inDocLink.tsx.ConnectSDKCard.tsx,WalletConnectorsChartCard.tsx,WalletDistributionChartCard.tsx,DailyConnectionsChartCard.tsx,TotalSponsoredChartCard.tsx, andSponsoredTransactionsChartCard.tsx.EmptyChartStateto acceptchildrenfor customizable content.DocLinkfor wallet connection instructions in multiple chart components.