redirect /team/~/... to /team/<first-team-slug>/... #5158

MananTank · 2024-10-24T11:46:38Z

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR introduces a new redirect functionality in the middleware for handling requests to /team/~/..., redirecting them to the first team's slug.

Detailed summary

Added a check for the path starting with team and ~.
Implemented a call to getTeams() to retrieve the list of teams.
Redirects to the first team's slug if available.
Maintains existing functionality for other paths.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

changeset-bot · 2024-10-24T11:46:42Z

⚠️ No Changeset found

Latest commit: 7185364

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

graphite-app · 2024-10-24T11:46:42Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

vercel · 2024-10-24T11:46:43Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 28, 2024 6:48pm

3 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)	Oct 28, 2024 6:48pm
thirdweb_playground	⬜️ Skipped (Inspect)	Oct 28, 2024 6:48pm
wallet-ui	⬜️ Skipped (Inspect)	Oct 28, 2024 6:48pm

MananTank · 2024-10-24T11:46:49Z

redirect /team/~/... to /team/<first-team-slug>/... #5158 👈
Move engine page components to app router folder in teams layout #5145
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite

apps/dashboard/src/middleware.ts

codecov · 2024-10-24T11:50:13Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.30%. Comparing base (efc8bb7) to head (7185364).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5158   +/-   ##
=======================================
  Coverage   45.30%   45.30%           
=======================================
  Files        1067     1067           
  Lines       55304    55304           
  Branches     3970     3970           
=======================================
  Hits        25054    25054           
  Misses      29557    29557           
  Partials      693      693

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from efc8bb7
packages	`40.31% <ø> (ø)`

*This pull request uses carry forward flags. Click here to find out more.

github-actions · 2024-10-24T11:51:58Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	42.9 KB (0%)	859 ms (0%)	1.8 s (+15.96% 🔺)	2.7 s
thirdweb (cjs)	102.73 KB (0%)	2.1 s (0%)	3.2 s (+14.82% 🔺)	5.2 s
thirdweb (minimal + tree-shaking)	4.84 KB (0%)	97 ms (0%)	189 ms (+209.46% 🔺)	286 ms
thirdweb/chains (tree-shaking)	498 B (0%)	10 ms (0%)	90 ms (+301.45% 🔺)	100 ms
thirdweb/react (minimal + tree-shaking)	17.34 KB (0%)	347 ms (0%)	357 ms (+38.49% 🔺)	704 ms

jnsdls · 2024-10-28T17:04:47Z

apps/dashboard/src/middleware.ts

    }
  }
+
+  // redirect /team/~/... to /team/<first_team_slug>/...


why can't this just be /team? why do we need the extra /~ in there?

If we want to have /team/ instead of /team/~/

That breaks the usual format - it should be /team/<team-slug>/<...otherSlugs>

We'll have to determine if otherSlugs[0] is not a valid team slug and then insert the first team's slug before them

I see you want to allow the deep-linking to something inside the default team - okay

jnsdls · 2024-10-28T17:05:09Z

apps/dashboard/src/middleware.ts

+    // TODO - need an API to get the first team to avoid fetching all teams
+    const teams = await getTeams();


yeah we need a getDefaultTeam

not a blocker however

jnsdls · 2024-10-28T17:37:29Z

apps/dashboard/src/middleware.ts

    }
  }
+
+  // redirect /team/~/... to /team/<first_team_slug>/...


I see you want to allow the deep-linking to something inside the default team - okay

graphite-app · 2024-10-28T17:45:37Z

Merge activity

Oct 28, 1:45 PM EDT: A user added this pull request to the Graphite merge queue.
Oct 28, 2:48 PM EDT: A user merged this pull request with the Graphite merge queue.

## Problem solved Short description of the bug fixed or feature added  --- ## PR-Codex overview This PR adds functionality to redirect requests from `/team/~/...` to `/team/<first_team_slug>/...`, enhancing user navigation by ensuring that users are directed to the first team's slug instead of a placeholder. ### Detailed summary - Added a check for the path starting with `team` and `~`. - Implemented a call to `getTeams()` to retrieve the list of teams. - If a team exists, modified the path to use the first team's slug. - Redirects the request to the new path format. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

vercel bot temporarily deployed to Preview – wallet-ui October 24, 2024 11:46 Inactive

vercel bot temporarily deployed to Preview – docs-v2 October 24, 2024 11:46 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground October 24, 2024 11:46 Inactive

MananTank mentioned this pull request Oct 24, 2024

Move engine page components to app router folder in teams layout #5145

Merged

MananTank marked this pull request as ready for review October 24, 2024 11:46

MananTank requested review from jnsdls and joaquim-verges as code owners October 24, 2024 11:46

github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 24, 2024

graphite-app bot reviewed Oct 24, 2024

View reviewed changes

apps/dashboard/src/middleware.ts Outdated Show resolved Hide resolved

MananTank force-pushed the 10-24-redirect__team___._to__team__first-team-slug__ branch from 80c6d2e to d288f46 Compare October 24, 2024 11:48

vercel bot temporarily deployed to Preview – docs-v2 October 24, 2024 11:48 Inactive

vercel bot temporarily deployed to Preview – wallet-ui October 24, 2024 11:48 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground October 24, 2024 11:48 Inactive

MananTank force-pushed the 10-24-redirect__team___._to__team__first-team-slug__ branch from d288f46 to 98e26da Compare October 24, 2024 11:48

vercel bot temporarily deployed to Preview – docs-v2 October 24, 2024 11:48 Inactive

vercel bot temporarily deployed to Preview – wallet-ui October 24, 2024 11:48 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground October 24, 2024 11:48 Inactive

vercel bot deployed to Preview – thirdweb-www October 24, 2024 12:05 View deployment

jnsdls reviewed Oct 28, 2024

View reviewed changes

MananTank requested a review from jnsdls October 28, 2024 17:35

jnsdls approved these changes Oct 28, 2024

View reviewed changes

MananTank changed the base branch from 10-24-move_engine_page_components_to_app_router_folder_in_teams_layout to graphite-base/5158 October 28, 2024 18:12

graphite-app bot changed the base branch from graphite-base/5158 to main October 28, 2024 18:36

MananTank force-pushed the 10-24-redirect__team___._to__team__first-team-slug__ branch from 98e26da to 7185364 Compare October 28, 2024 18:37

vercel bot temporarily deployed to Preview – docs-v2 October 28, 2024 18:37 Inactive

vercel bot temporarily deployed to Preview – wallet-ui October 28, 2024 18:37 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground October 28, 2024 18:37 Inactive

vercel bot deployed to Preview – thirdweb-www October 28, 2024 18:48 View deployment

graphite-app bot merged commit 7185364 into main Oct 28, 2024
31 checks passed

graphite-app bot deleted the 10-24-redirect__team___._to__team__first-team-slug__ branch October 28, 2024 18:48

vercel bot temporarily deployed to Production – wallet-ui October 28, 2024 18:48 Inactive

vercel bot temporarily deployed to Production – thirdweb_playground October 28, 2024 18:48 Inactive

vercel bot temporarily deployed to Production – docs-v2 October 28, 2024 18:48 Inactive

vercel bot deployed to Production – thirdweb-www October 28, 2024 18:58 View deployment

		// TODO - need an API to get the first team to avoid fetching all teams
		const teams = await getTeams();

redirect /team/~/... to /team/<first-team-slug>/... #5158

redirect /team/~/... to /team/<first-team-slug>/... #5158

Uh oh!

Conversation

MananTank commented Oct 24, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem solved

PR-Codex overview

Detailed summary

Uh oh!

changeset-bot bot commented Oct 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

graphite-app bot commented Oct 24, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

vercel bot commented Oct 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MananTank commented Oct 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Oct 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Oct 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

jnsdls Oct 28, 2024

Choose a reason for hiding this comment

Uh oh!

MananTank Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jnsdls Oct 28, 2024

Choose a reason for hiding this comment

Uh oh!

jnsdls Oct 28, 2024

Choose a reason for hiding this comment

Uh oh!

jnsdls Oct 28, 2024

Choose a reason for hiding this comment

Uh oh!

jnsdls Oct 28, 2024

Choose a reason for hiding this comment

Uh oh!

graphite-app bot commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MananTank commented Oct 24, 2024 •

edited by pr-codex bot

Loading

changeset-bot bot commented Oct 24, 2024 •

edited

Loading

vercel bot commented Oct 24, 2024 •

edited

Loading

MananTank commented Oct 24, 2024 •

edited

Loading

codecov bot commented Oct 24, 2024 •

edited

Loading

github-actions bot commented Oct 24, 2024 •

edited

Loading

MananTank Oct 28, 2024 •

edited

Loading

graphite-app bot commented Oct 28, 2024 •

edited

Loading