[Dashboard] Fix: Exclude testnet $ from total sponsored #5166
+20
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregfromstl
requested review from
MananTank,
jnsdls and
joaquim-verges
as code owners
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
gregfromstl
added
Bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5166 +/- ##
=======================================
Coverage 45.35% 45.35%
=======================================
Files 1068 1068
Lines 55230 55230
Branches 3971 3971
=======================================
Hits 25050 25050
Misses 29488 29488
Partials 692 692
*This pull request uses carry forward flags. Click here to find out more. |
joaquim-verges
approved these changes
Oct 24, 2024
Contributor
size-limit report 📦
|
gregfromstl
added
the
merge-queue
Contributor
Author
Merge activity
|
gregfromstl
added a commit
that referenced
this pull request
Oct 24, 2024
<!-- start pr-codex -->
## PR-Codex overview
This PR focuses on improving the usage and handling of user operation statistics in the `useUserOpUsageAggregate` function by incorporating chain data and refining the conditions under which statistics are aggregated.
### Detailed summary
- Updated the condition in `stat.tsx` to check for `value !== undefined` instead of `value &&`.
- Added the import of `useAllChainsData` in `useApi.ts`.
- Introduced `chainStore` to access chain data in `useUserOpUsageAggregate`.
- Modified the type of `userOpStats` to include an optional `chainId`.
- Added logic to skip aggregating stats for testnets.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
gregfromstl
force-pushed
the
fix/exclude-testnets
branch
from
6dbaad2 to
0fbcca1
Compare
gregfromstl
added a commit
that referenced
this pull request
Oct 24, 2024
<!-- start pr-codex -->
## PR-Codex overview
This PR focuses on improving the handling of analytics data in the `stat.tsx` component and enhancing the `useUserOpUsageAggregate` function in `useApi.ts` to include chain data and filter out testnets.
### Detailed summary
- In `stat.tsx`, updated the conditional rendering for `value` to check for `undefined` instead of using a truthy check.
- In `useApi.ts`, imported `useAllChainsData` for accessing chain information.
- Modified `userOpStats` to include an optional `chainId`.
- Added logic to skip testnets in the aggregated stats calculation.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
gregfromstl
force-pushed
the
fix/exclude-testnets
branch
from
0fbcca1 to
90a6804
Compare
<!-- start pr-codex -->
## PR-Codex overview
This PR focuses on improving the handling of analytics data in the `useUserOpUsageAggregate` function by incorporating chain data and refining the conditional rendering in the `stat.tsx` component.
### Detailed summary
- In `stat.tsx`, changed the conditional rendering to check for `value !== undefined` instead of `value &&`.
- In `useApi.ts`, imported `useAllChainsData` for accessing chain data.
- Added `chainStore` to hold all chains data.
- Modified `userOpStats` type to include `chainId`.
- Implemented a check to skip testnets in aggregated stats based on `chainId`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
gregfromstl
force-pushed
the
fix/exclude-testnets
branch
from
90a6804 to
cd22bca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on enhancing the
useUserOpUsageAggregatehook in theuseApi.tsfile by incorporating chain data and refining the aggregation logic to exclude testnets. Additionally, it updates the rendering logic instat.tsxfor better handling ofvalueandformatter.Detailed summary
stat.tsxto check forvalueusing!== undefined.useAllChainsDataimport inuseApi.ts.chainStoreto access chain data inuseUserOpUsageAggregate.userOpStatstype to include optionalchainId.