Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Oct 24, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on reducing the strictness in parsing published event actions within the @thirdweb-dev/service-utils package.

Detailed summary

  • Updated @thirdweb-dev/service-utils to a patch version.
  • Adjusted the parsing logic for published event actions to allow for more flexibility.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 24, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel
Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 11:33pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 11:33pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 11:33pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 11:33pm

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2024

🦋 Changeset detected

Latest commit: f23911e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/service-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gregfromstl gregfromstl self-assigned this Oct 24, 2024
@codecov
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.35%. Comparing base (cd22bca) to head (f23911e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5169   +/-   ##
=======================================
  Coverage   45.35%   45.35%           
=======================================
  Files        1068     1068           
  Lines       55230    55230           
  Branches     3971     3971           
=======================================
  Hits        25050    25050           
  Misses      29488    29488           
  Partials      692      692           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from cd22bca
packages 40.36% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.9 KB (0%) 859 ms (0%) 882 ms (+120.56% 🔺) 1.8 s
thirdweb (cjs) 102.73 KB (0%) 2.1 s (0%) 1.5 s (+1.34% 🔺) 3.5 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 73 ms (+253.15% 🔺) 169 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 357 ms (+1198.27% 🔺) 367 ms
thirdweb/react (minimal + tree-shaking) 17.34 KB (0%) 347 ms (0%) 409 ms (+468.42% 🔺) 756 ms

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Oct 24, 2024
Copy link
Contributor Author

gregfromstl commented Oct 24, 2024

Merge activity

  • Oct 24, 7:15 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 24, 7:29 PM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 24, 7:34 PM EDT: A user merged this pull request with the Graphite merge queue.

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on reducing the strictness of the parsing for published event actions in the `@thirdweb-dev/service-utils` package.

### Detailed summary
- Updated the `@thirdweb-dev/service-utils` package to a patch version.
- Modified the parsing logic for published event actions to be less strict, allowing for more flexible handling of events.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-queue Adds the pull request to Graphite's merge queue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants