Skip to content

feat: set initial balance for Anvil proxy in tests #5174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2024
Merged

feat: set initial balance for Anvil proxy in tests #5174

merged 1 commit into from
Oct 25, 2024

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 25, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on enhancing the testing functionality for the smart-wallet integration by adding a delay before sending a transaction and introducing a new option for the startProxy function.

Detailed summary

  • Added an options parameter with a balance of 1000000000n to the startProxy function in globalSetup.ts.
  • Imported the sleep function in smart-wallet-integration.test.ts.
  • Implemented a delay of 1000 milliseconds before calling sendAndConfirmTransaction in the test for the smart-wallet.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 🛑 Canceled (Inspect) Oct 25, 2024 8:12am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 8:12am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 8:12am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 8:12am

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5fc690d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 25, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@joaquim-verges joaquim-verges marked this pull request as ready for review October 25, 2024 07:45
@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Oct 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@joaquim-verges joaquim-verges force-pushed the feat_set_initial_balance_for_Anvil_proxy_in_tests branch from 908ac09 to 62521e3 Compare October 25, 2024 07:47
@joaquim-verges joaquim-verges force-pushed the feat_set_initial_balance_for_Anvil_proxy_in_tests branch from 62521e3 to 5fc690d Compare October 25, 2024 07:50
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.9 KB (0%) 859 ms (0%) 625 ms (+85.3% 🔺) 1.5 s
thirdweb (cjs) 102.73 KB (0%) 2.1 s (0%) 958 ms (+16.97% 🔺) 3.1 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 52 ms (-40.98% 🔽) 149 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 215 ms (+1874.11% 🔺) 225 ms
thirdweb/react (minimal + tree-shaking) 17.34 KB (0%) 347 ms (0%) 184 ms (+93.32% 🔺) 531 ms

@joaquim-verges joaquim-verges merged commit bafa0e8 into main Oct 25, 2024
26 of 28 checks passed
@joaquim-verges joaquim-verges deleted the feat_set_initial_balance_for_Anvil_proxy_in_tests branch October 25, 2024 07:58
@codecov
Copy link

codecov bot commented Oct 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.36%. Comparing base (5dc1899) to head (5fc690d).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5174   +/-   ##
=======================================
  Coverage   45.36%   45.36%           
=======================================
  Files        1068     1068           
  Lines       55230    55230           
  Branches     3971     3971           
=======================================
  Hits        25055    25055           
  Misses      29483    29483           
  Partials      692      692
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 5dc1899
packages 40.38% <ø> (ø) Carriedforward from 5dc1899

*This pull request uses carry forward flags. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gregfromstl gregfromstl Awaiting requested review from gregfromstl

@jnsdls jnsdls Awaiting requested review from jnsdls

Assignees

No one assigned

Labels

packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joaquim-verges