Skip to content

Include chain overrides for all chains and not just custom chains in RSCs #5197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2024
Merged

Include chain overrides for all chains and not just custom chains in RSCs #5197

merged 1 commit into from
Oct 28, 2024

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 28, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on reformatting code in the getContractFromParams.ts file to improve readability without changing functionality.

Detailed summary

  • Removed unnecessary line breaks for better readability.
  • Maintained the logic of checking localChainStoreValue and parsing it.
  • Preserved the structure for finding chainMetadata from chainOverrides.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 286aa30

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel
Copy link

vercel bot commented Oct 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 9:25pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 28, 2024 9:25pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 28, 2024 9:25pm
wallet-ui ⬜️ Skipped (Inspect) Oct 28, 2024 9:25pm

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 28, 2024
@MananTank Graphite App
Copy link
Member Author

MananTank commented Oct 28, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@MananTank MananTank mentioned this pull request Oct 28, 2024
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.9 KB (0%) 859 ms (0%) 3.3 s (+23.7% 🔺) 4.1 s
thirdweb (cjs) 102.73 KB (0%) 2.1 s (0%) 6.9 s (+29.06% 🔺) 8.9 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 137 ms (-68.32% 🔽) 234 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 99 ms (+45.94% 🔺) 109 ms
thirdweb/react (minimal + tree-shaking) 17.34 KB (0%) 347 ms (0%) 735 ms (+54.94% 🔺) 1.1 s

@MananTank MananTank marked this pull request as ready for review October 28, 2024 19:43
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 28, 2024 •
edited
Loading

Merge activity

@MananTank
Include chain overrides for all chains and not just custom chains in …
286aa30 
…RSCs (#5197)

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on refactoring the code in the `getContractFromParams.ts` file to improve readability. It mainly involves reordering and aligning the code without changing the logic.

### Detailed summary
- Removed unnecessary line breaks for better readability.
- Maintained the structure of the `if` statements and the `try-catch` block.
- Ensured consistent formatting for the `chainOverrides.find` function.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 10-29-include_chain_overrides_for_all_chains_and_not_just_custom_chains_in_rscs branch from e01971d to 286aa30 Compare October 28, 2024 21:16
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 28, 2024 21:16 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 28, 2024 21:16 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 28, 2024 21:16 Inactive
@codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.30%. Comparing base (bb44352) to head (286aa30).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5197   +/-   ##
=======================================
  Coverage   45.30%   45.30%           
=======================================
  Files        1067     1067           
  Lines       55304    55304           
  Branches     3970     3970           
=======================================
  Hits        25054    25054           
  Misses      29557    29557           
  Partials      693      693
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from bb44352
packages 40.31% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@graphite-app graphite-app bot merged commit 286aa30 into main Oct 28, 2024
31 checks passed
@graphite-app graphite-app bot deleted the 10-29-include_chain_overrides_for_all_chains_and_not_just_custom_chains_in_rscs branch October 28, 2024 21:25
@vercel vercel bot temporarily deployed to Production – docs-v2 October 28, 2024 21:25 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 28, 2024 21:25 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 28, 2024 21:25 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls