Skip to content

Fix turbo env variable warnings for dashboard build on vercel #5208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2024
Merged

Fix turbo env variable warnings for dashboard build on vercel #5208

merged 1 commit into from
Oct 28, 2024

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 28, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR updates the turbo.json configuration by adding several environment variables necessary for the build process, enhancing the setup for various integrations and services.

Detailed summary

  • Added multiple environment variables under the thirdweb-dashboard#build section:
    • MORALIS_API_KEY
    • ETHERSCAN_KEY
    • SSR_ALCHEMY_KEY
    • BEEHIIV_API_KEY
    • GITHUB_API_TOKEN
    • LUMA_API_KEY
    • HUBSPOT_ACCESS_TOKEN
    • API_ROUTES_CLIENT_ID
    • DASHBOARD_SECRET_KEY
    • SIMPLEHASH_API_KEY
    • NEYNAR_API_KEY
    • THIRDWEB_ENGINE_URL
    • THIRDWEB_ACCESS_TOKEN
    • THIRDWEB_ENGINE_ACCESS_TOKEN
    • DEGEN_THIRDWEB_ENGINE_WALLET
    • THIRDWEB_ENGINE_WALLET
    • UNTHREAD_TRIAGE_CHANNEL_ID
    • UNTHREAD_EMAIL_INBOX_ID
    • UNTHREAD_FREE_TIER_ID
    • UNTHREAD_GROWTH_TIER_ID
    • UNTHREAD_PRO_TIER_ID
    • REDIS_URL
    • UNTHREAD_API_KEY
    • CHAINSAW_API_KEY
    • ANALYTICS_SERVICE_URL
    • ANALYTICS_SERVICE_API_KEY
    • DISABLE_FAUCET_CHAIN_IDS
    • API_SERVER_SECRET
    • TURNSTILE_SECRET_KEY

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 10:24pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 10:24pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 10:24pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 10:24pm

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0b3fe51

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@MananTank MananTank marked this pull request as ready for review October 28, 2024 21:43
@MananTank Graphite App
Copy link
Member Author

MananTank commented Oct 28, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.9 KB (0%) 859 ms (0%) 3.6 s (+3.91% 🔺) 4.4 s
thirdweb (cjs) 102.73 KB (0%) 2.1 s (0%) 6.8 s (-3.86% 🔽) 8.8 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 578 ms (+52.68% 🔺) 675 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 139 ms (+202.71% 🔺) 149 ms
thirdweb/react (minimal + tree-shaking) 17.34 KB (0%) 347 ms (0%) 371 ms (-53.02% 🔽) 718 ms

@MananTank MananTank mentioned this pull request Oct 28, 2024
Merged
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 28, 2024 •
edited
Loading

Merge activity

@MananTank
Fix turbo env variable warnings for dashboard build on vercel (#5208)
0b3fe51 
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the `env` configuration in the `turbo.json` file to include additional environment variables necessary for the build process.

### Detailed summary
- Added multiple environment variables to the `env` array in the `thirdweb-dashboard#build` section:
  - `MORALIS_API_KEY`
  - `ETHERSCAN_KEY`
  - `SSR_ALCHEMY_KEY`
  - `BEEHIIV_API_KEY`
  - `GITHUB_API_TOKEN`
  - `LUMA_API_KEY`
  - `HUBSPOT_ACCESS_TOKEN`
  - `API_ROUTES_CLIENT_ID`
  - `DASHBOARD_SECRET_KEY`
  - `SIMPLEHASH_API_KEY`
  - `NEYNAR_API_KEY`
  - `THIRDWEB_ENGINE_URL`
  - `THIRDWEB_ACCESS_TOKEN`
  - `THIRDWEB_ENGINE_ACCESS_TOKEN`
  - `DEGEN_THIRDWEB_ENGINE_WALLET`
  - `THIRDWEB_ENGINE_WALLET`
  - `UNTHREAD_TRIAGE_CHANNEL_ID`
  - `UNTHREAD_EMAIL_INBOX_ID`
  - `UNTHREAD_FREE_TIER_ID`
  - `UNTHREAD_GROWTH_TIER_ID`
  - `UNTHREAD_PRO_TIER_ID`
  - `REDIS_URL`
  - `UNTHREAD_API_KEY`
  - `CHAINSAW_API_KEY`
  - `ANALYTICS_SERVICE_URL`
  - `ANALYTICS_SERVICE_API_KEY`
  - `DISABLE_FAUCET_CHAIN_IDS`
  - `API_SERVER_SECRET`
  - `TURNSTILE_SECRET_KEY`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 10-29-fix_turbo_env_variable_warnings_for_dashboard_build_on_vercel branch from d61fff9 to 0b3fe51 Compare October 28, 2024 22:15
@graphite-app graphite-app bot merged commit 0b3fe51 into main Oct 28, 2024
28 checks passed
@graphite-app graphite-app bot deleted the 10-29-fix_turbo_env_variable_warnings_for_dashboard_build_on_vercel branch October 28, 2024 22:25
@codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.25%. Comparing base (adeda1e) to head (0b3fe51).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5208   +/-   ##
=======================================
  Coverage   45.25%   45.25%           
=======================================
  Files        1067     1067           
  Lines       55347    55347           
  Branches     3970     3970           
=======================================
  Hits        25049    25049           
  Misses      29606    29606           
  Partials      692      692
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from adeda1e
packages 40.26% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges joaquim-verges is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls