feat: improve ecosystem smart account handling #5212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 6c37aee The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
github-actions
bot
added
Dashboard
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @joaquim-verges and the rest of your teammates on |
joaquim-verges
requested review from
MananTank,
edwardysun,
gregfromstl and
jnsdls
as code owners
Contributor
size-limit report 📦
|
joaquim-verges
force-pushed
the
feat_improve_ecosystem_smart_account_handling
branch
from
31f9b8e to
6c37aee
Compare
joaquim-verges
deleted the
feat_improve_ecosystem_smart_account_handling
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on improving the handling of ecosystem smart accounts within the
thirdwebpackage. It enhances the logic for checking smart accounts and updates the related functions to ensure better integration and data fetching.Detailed summary
hasSmartAccountfunction to refine smart account checks.getEcosystemOptionstogetEcosystemInfofor clarity.getEcosystemWalletInfo.AuthOptionsFormto handle custom account factory addresses.createInAppWallet.