Skip to content

[Dashboard] (test) Unit conversion for ERC20 claim condition #5235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Dashboard] (test) Unit conversion for ERC20 claim condition #5235

wants to merge 1 commit into from

Conversation

@kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Oct 30, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR enhances the claim-conditions functionality by adding the toBigInt and toTokens utility functions, improving how token quantities are handled, and ensuring correct conversions for ERC20 tokens in the claim conditions form.

Detailed summary

  • Added toBigInt function to convert values to BigInt.
  • Integrated toTokens for converting token amounts based on decimals.
  • Updated maxClaimableSupply and maxClaimablePerWallet to handle "unlimited" cases.
  • Enhanced error handling for fetching token metadata.
  • Updated the claim conditions form to use new utility functions for ERC20 token conversions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 22927c0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 30, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel
Copy link

vercel bot commented Oct 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 5:15pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 30, 2024 5:15pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 30, 2024 5:15pm
wallet-ui ⬜️ Skipped (Inspect) Oct 30, 2024 5:15pm

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 30, 2024
@kien-ngo kien-ngo changed the title Update [Dashboard] (test) Unit conversion for ERC20 claim condition Oct 30, 2024
@kien-ngo Graphite App
Copy link
Contributor Author

kien-ngo commented Oct 30, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite Graphite

@kien-ngo kien-ngo marked this pull request as ready for review October 30, 2024 16:07
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 861 ms (0%) 2.5 s (-10.76% 🔽) 3.4 s
thirdweb (cjs) 102.91 KB (0%) 2.1 s (0%) 7.4 s (-5.21% 🔽) 9.5 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 182 ms (+7.09% 🔺) 279 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 92 ms (+27.6% 🔺) 102 ms
thirdweb/react (minimal + tree-shaking) 17.38 KB (0%) 348 ms (0%) 751 ms (+44.52% 🔺) 1.1 s

@codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.29%. Comparing base (519349b) to head (22927c0).
Report is 46 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5235      +/-   ##
==========================================
- Coverage   45.29%   45.29%   -0.01%     
==========================================
  Files        1067     1068       +1     
  Lines       55341    55380      +39     
  Branches     3973     3975       +2     
==========================================
+ Hits        25068    25082      +14     
- Misses      29581    29606      +25     
  Partials      692      692
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 519349b
packages 40.30% <ø> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 5 files with indirect coverage changes

@kien-ngo kien-ngo force-pushed the kien/claim0condition-erc20 branch from 2a27e74 to c1adba1 Compare October 30, 2024 16:32
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 30, 2024 16:32 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 30, 2024 16:32 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 30, 2024 16:32 Inactive
@kien-ngo kien-ngo force-pushed the kien/claim0condition-erc20 branch from c1adba1 to 22927c0 Compare October 30, 2024 17:06
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 30, 2024 17:06 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 30, 2024 17:06 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 30, 2024 17:06 Inactive
@kien-ngo kien-ngo marked this pull request as draft October 31, 2024 10:30
@kien-ngo kien-ngo added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Oct 31, 2024 — with Graphite App
@kien-ngo kien-ngo closed this Nov 4, 2024
@kien-ngo kien-ngo deleted the kien/claim0condition-erc20 branch January 6, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@jnsdls jnsdls Awaiting requested review from jnsdls

@MananTank MananTank Awaiting requested review from MananTank

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

@kien-ngo kien-ngo

Labels

Dashboard Involves changes to the Dashboard. DO NOT MERGE This pull request is still in progress and is not ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kien-ngo