feat: add support for custom singlePhase drops #5244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 22df316 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @joaquim-verges and the rest of your teammates on |
Contributor
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5244 +/- ##
==========================================
+ Coverage 45.29% 45.32% +0.03%
==========================================
Files 1067 1067
Lines 55374 55433 +59
Branches 3978 3990 +12
==========================================
+ Hits 25081 25126 +45
- Misses 29601 29615 +14
Partials 692 692
*This pull request uses carry forward flags. Click here to find out more.
|
joaquim-verges
force-pushed
the
feat_add_support_for_custom_singlePhase_drops
branch
from
3a7d866 to
b389cf1
Compare
joaquim-verges
force-pushed
the
feat_add_support_for_custom_singlePhase_drops
branch
from
b389cf1 to
22df316
Compare
joaquim-verges
deleted the
feat_add_support_for_custom_singlePhase_drops
branch
Merged
jnsdls
pushed a commit
that referenced
this pull request
Nov 1, 2024
jnsdls
pushed a commit
that referenced
this pull request
Nov 5, 2024
jnsdls
pushed a commit
that referenced
this pull request
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Fixes CNCT-2146
PR-Codex overview
This PR adds support for
singlePhaseDropfunctionality in thethirdwebSDK, allowing users to set claim conditions and claim tokens in a single phase for custom drop contracts.Detailed summary
singlePhaseDropoption insetClaimConditionsandclaimTofunctions.ERC20,ERC721, andERC1155extensions.singlePhaseDrop.ClaimConditionUpdatedandTokensClaimed.CustomDropERC20andCustomDropERC1155to validate new functionality.