Skip to content

fix: respect custom paymaster callback #5246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix: respect custom paymaster callback #5246

merged 1 commit into from
Oct 31, 2024

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 31, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on fixing the custom paymaster callback handling in the thirdweb package and adding a test to ensure the new behavior works as expected.

Detailed summary

  • Updated paymasterOverride logic in packages/thirdweb/src/wallets/smart/index.ts to respect the custom paymaster callback.
  • Added a new test case in packages/thirdweb/src/wallets/smart/smart-wallet-integration.test.ts to validate the use of a different paymaster.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 8:38am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 8:38am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 8:38am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 8:38am

@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2024

🦋 Changeset detected

Latest commit: f5201f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 31, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@joaquim-verges joaquim-verges marked this pull request as ready for review October 31, 2024 08:26
@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Oct 31, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 861 ms (0%) 789 ms (+115.65% 🔺) 1.7 s
thirdweb (cjs) 102.91 KB (0%) 2.1 s (0%) 1.1 s (+0.08% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 185 ms (+259.08% 🔺) 282 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 463 ms (+3892.73% 🔺) 473 ms
thirdweb/react (minimal + tree-shaking) 17.38 KB (0%) 348 ms (0%) 421 ms (+188.32% 🔺) 769 ms

@codecov
Copy link

codecov bot commented Oct 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.43%. Comparing base (60629e3) to head (f5201f5).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5246      +/-   ##
==========================================
+ Coverage   45.31%   45.43%   +0.11%     
==========================================
  Files        1068     1067       -1     
  Lines       55461    55435      -26     
  Branches     3989     4010      +21     
==========================================
+ Hits        25132    25185      +53     
+ Misses      29637    29559      -78     
+ Partials      692      691       -1
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 60629e3
packages 40.48% <100.00%> (+0.14%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
packages/thirdweb/src/wallets/smart/index.ts 65.56% <100.00%> (+0.52%) ⬆️

... and 5 files with indirect coverage changes

@joaquim-verges joaquim-verges merged commit 82c8726 into main Oct 31, 2024
29 of 31 checks passed
@joaquim-verges joaquim-verges deleted the fix_respect_custom_paymaster_callback branch October 31, 2024 08:35
@jnsdls jnsdls mentioned this pull request Oct 31, 2024
Merged
jnsdls pushed a commit that referenced this pull request Nov 1, 2024
@joaquim-verges @jnsdls
fix: respect custom paymaster callback (#5246)
a487893
jnsdls pushed a commit that referenced this pull request Nov 5, 2024
@joaquim-verges @jnsdls
fix: respect custom paymaster callback (#5246)
3432fac
jnsdls pushed a commit that referenced this pull request Nov 5, 2024
@joaquim-verges @jnsdls
fix: respect custom paymaster callback (#5246)
2040ca0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gregfromstl gregfromstl Awaiting requested review from gregfromstl

@jnsdls jnsdls Awaiting requested review from jnsdls

Assignees

No one assigned

Labels

packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joaquim-verges