Skip to content

fix: use stringify helper for bigint serialization #5253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2024
Merged

fix: use stringify helper for bigint serialization #5253

merged 1 commit into from
Nov 1, 2024

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 31, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on replacing JSON.stringify with stringify in various parts of the codebase to improve bigint serialization handling.

Detailed summary

  • Updated error handling in bundler.ts to use stringify.
  • Modified verify-jwt.ts to use stringify for payload serialization.
  • Changed error message creation in errors.ts to use stringify.
  • Altered object cloning in utils.ts to use stringify.
  • Updated local storage interactions in local.ts to use stringify.
  • Replaced JSON.stringify with stringify in multiple request bodies across several files, including paymaster.ts, authEndpoint.ts, and others.
  • Adjusted JWT encoding in encode-jwt.ts to utilize stringify.
  • Enhanced session storage methods to use stringify in session-store.ts.
  • Updated error handling in various parts of the codebase to improve error message formatting using stringify.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 7:11pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 7:11pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 7:11pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 7:11pm

@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: baf2198

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 31, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@joaquim-verges joaquim-verges marked this pull request as ready for review October 31, 2024 20:46
@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Oct 31, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (+0.01% 🔺) 861 ms (+0.01% 🔺) 402 ms (-11.9% 🔽) 1.3 s
thirdweb (cjs) 102.88 KB (-0.04% 🔽) 2.1 s (-0.04% 🔽) 851 ms (-1.86% 🔽) 3 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 82 ms (+125.37% 🔺) 179 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 57 ms (+664.86% 🔺) 67 ms
thirdweb/react (minimal + tree-shaking) 17 KB (+0.13% 🔺) 341 ms (+0.13% 🔺) 207 ms (+321.39% 🔺) 548 ms

@codecov
Copy link

codecov bot commented Oct 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 59.37500% with 13 lines in your changes missing coverage. Please review.

Project coverage is 45.37%. Comparing base (7a86344) to head (baf2198).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ckages/thirdweb/src/utils/storage/walletStorage.ts 25.00% 3 Missing ⚠️
...utils/extensions/airdrop/process-snapshot-erc20.ts 0.00% 2 Missing ⚠️
...tils/extensions/airdrop/process-snapshot-erc721.ts 0.00% 2 Missing ⚠️
...ackages/thirdweb/src/pay/buyWithCrypto/getQuote.ts 0.00% 1 Missing ⚠️
...ages/thirdweb/src/pay/buyWithCrypto/getTransfer.ts 0.00% 1 Missing ⚠️
packages/thirdweb/src/pay/buyWithFiat/getQuote.ts 0.00% 1 Missing ⚠️
...dweb/src/wallets/in-app/core/wallet/in-app-core.ts 0.00% 1 Missing ⚠️
packages/thirdweb/src/wallets/manager/index.ts 66.66% 1 Missing ⚠️
.../thirdweb/src/wallets/wallet-connect/controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5253      +/-   ##
==========================================
- Coverage   45.37%   45.37%   -0.01%     
==========================================
  Files        1067     1067              
  Lines       55450    55446       -4     
  Branches     3989     3989              
==========================================
- Hits        25161    25157       -4     
  Misses      29598    29598              
  Partials      691      691
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 7a86344
packages 40.41% <59.37%> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
packages/thirdweb/src/auth/core/verify-jwt.ts 45.76% <100.00%> (ø)
packages/thirdweb/src/rpc/rpc.ts 66.66% <100.00%> (ø)
...ils/extensions/airdrop/process-snapshot-erc1155.ts 91.78% <100.00%> (ø)
...rc/utils/extensions/drops/process-override-list.ts 96.10% <100.00%> (ø)
packages/thirdweb/src/utils/jwt/encode-jwt.ts 84.00% <100.00%> (-0.62%) ⬇️
packages/thirdweb/src/wallets/smart/lib/bundler.ts 62.50% <100.00%> (ø)
...ckages/thirdweb/src/wallets/smart/lib/paymaster.ts 64.17% <100.00%> (ø)
...c/wallets/wallet-connect/receiver/session-store.ts 94.00% <100.00%> (-0.45%) ⬇️
...ackages/thirdweb/src/pay/buyWithCrypto/getQuote.ts 1.25% <0.00%> (ø)
...ages/thirdweb/src/pay/buyWithCrypto/getTransfer.ts 1.61% <0.00%> (ø)
... and 7 more

gregfromstl
gregfromstl approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@gregfromstl gregfromstl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 1, 2024
@joaquim-verges
fix: use stringify helper for bigint serialization (#5253)
baf2198 
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on replacing `JSON.stringify` with `stringify` in various parts of the codebase to improve bigint serialization handling.

### Detailed summary
- Updated error handling in `bundler.ts` to use `stringify`.
- Modified payload serialization in `verify-jwt.ts`, `native/helpers/errors.ts`, and others to use `stringify`.
- Changed data storage and retrieval methods in various files to utilize `stringify`.
- Adjusted JWT encoding in `encode-jwt.ts` to use `stringify`.
- Enhanced error messages and responses across multiple files by replacing `JSON.stringify` with `stringify`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@joaquim-verges joaquim-verges force-pushed the fix_use_stringify_helper_for_bigint_serialization branch from 4650ef9 to baf2198 Compare November 1, 2024 18:57
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 1, 2024

Merge activity

@graphite-app graphite-app bot merged commit baf2198 into main Nov 1, 2024
31 checks passed
@graphite-app graphite-app bot deleted the fix_use_stringify_helper_for_bigint_serialization branch November 1, 2024 19:11
@jnsdls jnsdls mentioned this pull request Nov 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MananTank MananTank Awaiting requested review from MananTank

@jnsdls jnsdls Awaiting requested review from jnsdls

@edwardysun edwardysun Awaiting requested review from edwardysun

1 more reviewer

@gregfromstl gregfromstl gregfromstl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

merge-queue Adds the pull request to Graphite's merge queue. packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joaquim-verges @gregfromstl