[SDK] Feature: Configure analytics URL #5270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0660416 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
Playground
Contributor
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5270 +/- ##
=======================================
Coverage 45.36% 45.37%
=======================================
Files 1067 1067
Lines 55449 55451 +2
Branches 3989 3992 +3
=======================================
+ Hits 25157 25161 +4
+ Misses 29601 29599 -2
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more.
|
gregfromstl
added
the
merge-queue
Contributor
Author
Merge activity
|
joaquim-verges
approved these changes
Nov 2, 2024
Member
joaquim-verges
left a comment
joaquim-verges
left a comment
There was a problem hiding this comment.
@gregfromstl check the size job? something bumped it
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR introduces the ability to configure the analytics endpoint for the `thirdweb` package, enhancing flexibility in specifying where analytics data is sent.
### Detailed summary
- Added a new configuration option for `analytics` in `apps/playground-web/src/lib/client.ts`.
- Replaced the hardcoded `ANALYTICS_ENDPOINT` URL with a dynamic URL using `getThirdwebBaseUrl` in `packages/thirdweb/src/analytics/track/index.ts`.
- Introduced a default value for `analytics` in `packages/thirdweb/src/utils/domains.ts`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
gregfromstl
force-pushed
the
feat/analytics-url-config
branch
from
1bdcd9e to
0660416
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on enabling the configuration of the analytics endpoint in the
thirdwebpackage, allowing users to customize where analytics data is sent.Detailed summary
analyticsconfiguration option inapps/playground-web/src/lib/client.ts.ANALYTICS_ENDPOINTwith a dynamic URL inpackages/thirdweb/src/analytics/track/index.ts.DEFAULT_ANALYTICS_URLinpackages/thirdweb/src/utils/domains.ts.domainsobject to includeanalyticswith a default value.