[React SDK] Feature: Adds SiteEmbed component
#5298
Merged
+184
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregfromstl
requested review from
MananTank,
edwardysun,
jnsdls and
joaquim-verges
as code owners
🦋 Changeset detectedLatest commit: 5cc5c93 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
gregfromstl
force-pushed
the
greg/cnct-2213-siteembed-component
branch
from
2c74927 to
1a00108
Compare
gregfromstl
force-pushed
the
greg/cnct-2213-siteembed-component
branch
from
1a00108 to
2bb6704
Compare
Contributor
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5298 +/- ##
==========================================
+ Coverage 45.56% 45.59% +0.02%
==========================================
Files 1067 1069 +2
Lines 55487 55584 +97
Branches 4031 4045 +14
==========================================
+ Hits 25283 25342 +59
- Misses 29514 29552 +38
Partials 690 690
*This pull request uses carry forward flags. Click here to find out more.
|
gregfromstl
force-pushed
the
greg/cnct-2213-siteembed-component
branch
from
e3290fc to
a235c7e
Compare
gregfromstl
force-pushed
the
greg/cnct-2213-siteembed-component
branch
from
a235c7e to
5abca99
Compare
joaquim-verges
approved these changes
Nov 5, 2024
gregfromstl
added
the
merge-queue
Contributor
Author
Merge activity
|
CNCT-2213 <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces a new `SiteEmbed` React component that allows embedding thirdweb-supported sites with wallet connection support. It enhances the user experience by maintaining wallet connection states across different sites. ### Detailed summary - Added `SiteEmbed` component for embedding thirdweb sites. - Updated `getUrlToken` to include `authCookie`. - Enhanced `useAutoConnectCore` to save `authCookie` if available. - Created tests for `SiteEmbed` component, ensuring iframe rendering and error handling. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
gregfromstl
force-pushed
the
greg/cnct-2213-siteembed-component
branch
from
5abca99 to
5cc5c93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CNCT-2213
PR-Codex overview
This PR introduces a new
SiteEmbedReact component that allows embedding thirdweb-supported sites with seamless wallet connection support. It enhances user experience by maintaining wallet connection states for both in-app and ecosystem wallets.Detailed summary
SiteEmbedcomponent for embedding thirdweb sites.SiteEmbedsupports seamless wallet connections.getUrlTokento includeauthCookie.useAutoConnectCoreto saveauthCookieif available.SiteEmbedto verify rendering and error handling.