Skip to content

add new framer rewrite paths and organize with comments #5299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2024
Merged

add new framer rewrite paths and organize with comments #5299

merged 1 commit into from
Nov 5, 2024

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Nov 5, 2024 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR updates the framer-rewrites.js file to modify the routing paths for the application. It adds new routes and organizes them with comments for better clarity.

Detailed summary

  • Added comments to categorize routes: home, product landing pages, connect, contracts, engine, solutions pages, and campaigns.
  • Added new routes:
    • "/contracts/explore"
    • "/contracts/deployment-tool"
    • "/solutions/defi"
    • "/unlimited-wallets" (moved from a previous position)
  • Removed the route "/unlimited-wallets" from its original position.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 70ed73e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 5, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel
Copy link

vercel bot commented Nov 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 1:13am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 5, 2024 1:13am
thirdweb_playground ⬜️ Skipped (Inspect) Nov 5, 2024 1:13am
wallet-ui ⬜️ Skipped (Inspect) Nov 5, 2024 1:13am

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 5, 2024
@jnsdls Graphite App
Copy link
Member Author

jnsdls commented Nov 5, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jnsdls and the rest of your teammates on Graphite Graphite

@jnsdls jnsdls marked this pull request as ready for review November 5, 2024 00:52
@codecov
Copy link

codecov bot commented Nov 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.44%. Comparing base (5398cb4) to head (70ed73e).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5299   +/-   ##
=======================================
  Coverage   45.44%   45.44%           
=======================================
  Files        1067     1067           
  Lines       55459    55459           
  Branches     4009     4009           
=======================================
  Hits        25206    25206           
  Misses      29562    29562           
  Partials      691      691
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 5398cb4
packages 40.51% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 860 ms (0%) 247 ms (+99.33% 🔺) 1.2 s
thirdweb (cjs) 103.02 KB (0%) 2.1 s (0%) 258 ms (-16.62% 🔽) 2.4 s
thirdweb (minimal + tree-shaking) 4.85 KB (0%) 97 ms (0%) 7 ms (-65.67% 🔽) 104 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 28 ms (+342.31% 🔺) 38 ms
thirdweb/react (minimal + tree-shaking) 17.57 KB (0%) 352 ms (0%) 29 ms (+14.05% 🔺) 381 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 5, 2024 •
edited
Loading

Merge activity

@jnsdls jnsdls force-pushed the add_new_framer_rewrite_paths_and_organize_with_comments branch from 6829153 to 70ed73e Compare November 5, 2024 01:03
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 5, 2024 01:03 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 5, 2024 01:03 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 5, 2024 01:03 Inactive
@jnsdls jnsdls mentioned this pull request Nov 5, 2024
Merged
@graphite-app graphite-app bot merged commit 70ed73e into main Nov 5, 2024
31 of 32 checks passed
@graphite-app graphite-app bot deleted the add_new_framer_rewrite_paths_and_organize_with_comments branch November 5, 2024 01:13
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 5, 2024 01:13 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 November 5, 2024 01:13 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui November 5, 2024 01:13 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquim-verges joaquim-verges joaquim-verges approved these changes

@MananTank MananTank Awaiting requested review from MananTank

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jnsdls @joaquim-verges