Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Nov 5, 2024

PR-Codex overview

This PR focuses on updating the Page components in various files to handle params and searchParams as Promises, ensuring asynchronous data retrieval before rendering the EcosystemPermissionsPage and EcosystemAnalyticsPage.

Detailed summary

  • Changed params type from { slug: string } to Promise<{ slug: string }> in page.tsx files.
  • Updated EcosystemPermissionsPage to await params in both dashboard and team project routes.
  • Modified EcosystemAnalyticsPage to accept Promise types for params and searchParams.
  • Used Promise.all to await both params and searchParams before fetching ecosystem data.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 6:40pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 5, 2024 6:40pm
thirdweb_playground ⬜️ Skipped (Inspect) Nov 5, 2024 6:40pm
wallet-ui ⬜️ Skipped (Inspect) Nov 5, 2024 6:40pm

@changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2024

⚠️ No Changeset found

Latest commit: 6469fd5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 5, 2024 18:20 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 5, 2024 18:20 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 5, 2024 18:20 Inactive
@MananTank MananTank marked this pull request as ready for review November 5, 2024 18:20
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 5, 2024
Copy link
Member Author

MananTank commented Nov 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.59%. Comparing base (6030bf1) to head (6469fd5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5311   +/-   ##
=======================================
  Coverage   45.59%   45.59%           
=======================================
  Files        1069     1069           
  Lines       55584    55584           
  Branches     4045     4045           
=======================================
  Hits        25342    25342           
  Misses      29552    29552           
  Partials      690      690           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 6030bf1
packages 40.70% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 861 ms (0%) 3.1 s (+33.84% 🔺) 3.9 s
thirdweb (cjs) 103 KB (0%) 2.1 s (0%) 6.8 s (+20.89% 🔺) 8.9 s
thirdweb (minimal + tree-shaking) 4.85 KB (0%) 97 ms (0%) 177 ms (-52.32% 🔽) 274 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 94 ms (+83.02% 🔺) 104 ms
thirdweb/react (minimal + tree-shaking) 17.51 KB (0%) 351 ms (0%) 847 ms (+188.22% 🔺) 1.2 s

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 5, 2024

Merge activity

@jnsdls jnsdls force-pushed the 11-05-fix_newly_added_pages_not_awaiting_the_params_and_searchparams branch from 199ffc1 to 6469fd5 Compare November 5, 2024 18:36
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 5, 2024 18:37 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 5, 2024 18:37 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 5, 2024 18:37 Inactive
@graphite-app graphite-app bot merged commit 6469fd5 into main Nov 5, 2024
31 checks passed
@graphite-app graphite-app bot deleted the 11-05-fix_newly_added_pages_not_awaiting_the_params_and_searchparams branch November 5, 2024 18:40
@vercel vercel bot temporarily deployed to Production – wallet-ui November 5, 2024 18:40 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 5, 2024 18:40 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 November 5, 2024 18:41 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants