Skip to content

[Dashboard] Update simplehash supported networks #5317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2024
Merged

[Dashboard] Update simplehash supported networks #5317

merged 1 commit into from
Nov 6, 2024
+4 −0

Conversation

@kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Nov 6, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR adds new supported NFT chains to the alchemySupportedChainIdsMap in the apps/dashboard/src/lib/wallet/nfts/types.ts file.

Detailed summary

  • Added new chain IDs:
    • sei
    • sei-atlantic-2
    • shape
    • apechain

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 3:51am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 6, 2024 3:51am
thirdweb_playground ⬜️ Skipped (Inspect) Nov 6, 2024 3:51am
wallet-ui ⬜️ Skipped (Inspect) Nov 6, 2024 3:51am

@vercel vercel bot temporarily deployed to Preview – docs-v2 November 6, 2024 03:35 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 6, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2024

⚠️ No Changeset found

Latest commit: 7120075

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui November 6, 2024 03:35 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 6, 2024 03:35 Inactive
@kien-ngo kien-ngo marked this pull request as ready for review November 6, 2024 03:35
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 6, 2024
@kien-ngo Graphite App
Copy link
Contributor Author

kien-ngo commented Nov 6, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Nov 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.61%. Comparing base (9fb2a71) to head (418e3e4).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5317   +/-   ##
=======================================
  Coverage   45.61%   45.61%           
=======================================
  Files        1068     1068           
  Lines       55556    55556           
  Branches     4047     4047           
=======================================
  Hits        25341    25341           
  Misses      29525    29525           
  Partials      690      690
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 9fb2a71
packages 40.72% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 861 ms (0%) 445 ms (-6.96% 🔽) 1.4 s
thirdweb (cjs) 103 KB (0%) 2.1 s (0%) 946 ms (+3.84% 🔺) 3.1 s
thirdweb (minimal + tree-shaking) 4.85 KB (0%) 97 ms (0%) 84 ms (+104.35% 🔺) 181 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 58 ms (+361.66% 🔺) 68 ms
thirdweb/react (minimal + tree-shaking) 17.51 KB (0%) 351 ms (0%) 271 ms (+170.94% 🔺) 622 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 6, 2024 •
edited
Loading

Merge activity

@kien-ngo
[Dashboard] Update simplehash supported networks (#5317)
418e3e4 
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates the `alchemySupportedChainIdsMap` in the `apps/dashboard/src/lib/wallet/nfts/types.ts` file by adding new supported chains.

### Detailed summary
- Added new entries to `alchemySupportedChainIdsMap`:
  - `"sei"` with key `[1329]`
  - `"sei-atlantic-2"` with key `[1328]`
  - `"shape"` with key `[360]`
  - `"apechain"` with key `[33139]`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@kien-ngo kien-ngo force-pushed the kien/dash-345_update-simplehash-supported-network branch from 7120075 to 418e3e4 Compare November 6, 2024 03:48
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 6, 2024 03:48 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 6, 2024 03:48 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 6, 2024 03:49 Inactive
@graphite-app graphite-app bot merged commit 418e3e4 into main Nov 6, 2024
31 checks passed
@graphite-app graphite-app bot deleted the kien/dash-345_update-simplehash-supported-network branch November 6, 2024 03:52
@vercel vercel bot temporarily deployed to Production – docs-v2 November 6, 2024 03:52 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui November 6, 2024 03:52 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 6, 2024 03:52 Inactive
@kien-ngo kien-ngo self-assigned this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquim-verges joaquim-verges joaquim-verges approved these changes

@jnsdls jnsdls Awaiting requested review from jnsdls

@MananTank MananTank Awaiting requested review from MananTank

Assignees

@kien-ngo kien-ngo

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kien-ngo @joaquim-verges