Fix Select selection not working on mobile device - radix fix no longer required #5321
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @MananTank and the rest of your teammates on |
MananTank
added
the
hotfix
Graphite App
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5321 +/- ##
=======================================
Coverage 45.71% 45.71%
=======================================
Files 1068 1068
Lines 55560 55560
Branches 4062 4062
=======================================
Hits 25402 25402
Misses 29469 29469
Partials 689 689
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
Merge activity
|
…er required (#5321) ## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on simplifying the `ref` handling in the `SelectPrimitive.Content` component of the `select.tsx` file by removing a custom `ref` function and replacing it with a direct assignment. It also enhances the component's class names for better styling based on its state. ### Detailed summary - Removed custom `ref` handling logic. - Directly assigned `ref` to `SelectPrimitive.Content`. - Updated `className` with various state-based styles for animations and positioning. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
MananTank
force-pushed
the
11-06-fix_select_selection_not_working_on_mobile_device_-_radix_fix_no_longer_required
branch
from
87463cc to
882f59b
Compare
|
graphite-app
bot
deleted the
11-06-fix_select_selection_not_working_on_mobile_device_-_radix_fix_no_longer_required
branch
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on simplifying the
refhandling in theSelectPrimitive.Contentcomponent and enhancing the styling with additional classes for animations and positioning.Detailed summary
refhandling logic.refassignment toref={ref}.classNamewith multiple state-based animations and positioning styles.