Skip to content

fix: unstoppable domains test #5389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2024
Merged

fix: unstoppable domains test #5389

merged 1 commit into from
Nov 12, 2024

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Nov 12, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR updates the test suite for resolving addresses using Unstoppable Domains. It modifies the test structure to conditionally run the tests based on the presence of TW_SECRET_KEY.

Detailed summary

  • Changed describe to describe.runIf(process.env.TW_SECRET_KEY) to conditionally run the tests.
  • Maintained the existing test cases for resolving addresses and handling non-existent domain names.
  • Reformatted the indentation and structure for better readability.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Nov 12, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 512eeb5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 9:10pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 9:10pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 9:10pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 9:10pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 12, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@gregfromstl gregfromstl self-assigned this Nov 12, 2024
@gregfromstl gregfromstl added merge-queue Adds the pull request to Graphite's merge queue. and removed packages labels Nov 12, 2024
@gregfromstl Graphite App
Copy link
Contributor Author

gregfromstl commented Nov 12, 2024 •
edited by graphite-app bot
Loading

Merge activity

  • Nov 11, 7:03 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 12, 3:56 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 12, 4:11 PM EST: A user merged this pull request with the Graphite merge queue.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.15 KB (0%) 883 ms (0%) 3.6 s (+6.13% 🔺) 4.5 s
thirdweb (cjs) 104.69 KB (0%) 2.1 s (0%) 5.6 s (-14.76% 🔽) 7.7 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 215 ms (-10.75% 🔽) 329 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 208 ms (+189.6% 🔺) 218 ms
thirdweb/react (minimal + tree-shaking) 18.78 KB (0%) 376 ms (0%) 417 ms (-49.12% 🔽) 793 ms

@vercel vercel bot temporarily deployed to Preview – docs-v2 November 12, 2024 17:23 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 12, 2024 17:23 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 12, 2024 17:23 Inactive
@codecov
Copy link

codecov bot commented Nov 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.32%. Comparing base (a1707f6) to head (512eeb5).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5389      +/-   ##
==========================================
- Coverage   45.33%   45.32%   -0.01%     
==========================================
  Files        1067     1067              
  Lines       55405    55405              
  Branches     4001     4001              
==========================================
- Hits        25116    25111       -5     
- Misses      29602    29607       +5     
  Partials      687      687
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from a1707f6
packages 40.34% <ø> (-0.02%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 2 files with indirect coverage changes

@gregfromstl
fix: unstoppable domains test (#5389)
512eeb5 
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR modifies the test suite for resolving addresses with `Unstoppable Domain`. It updates the test structure to conditionally run based on the presence of `TW_SECRET_KEY` and retains the existing test logic.

### Detailed summary
- Changed `describe` to conditionally run with `describe.runIf(process.env.TW_SECRET_KEY)`.
- Retained the test for resolving a valid address.
- Retained the test for handling a non-existent domain name.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@gregfromstl gregfromstl force-pushed the fix/unstoppable-domains-test branch from a223673 to 512eeb5 Compare November 12, 2024 20:57
@graphite-app graphite-app bot merged commit 512eeb5 into main Nov 12, 2024
31 of 32 checks passed
@graphite-app graphite-app bot deleted the fix/unstoppable-domains-test branch November 12, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

@gregfromstl gregfromstl

Labels

merge-queue Adds the pull request to Graphite's merge queue. packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gregfromstl @jnsdls