[Dashboard] Fix: Catch localStorage getItem and setItem unhandled errors #5397
+55
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 895b4d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
github-actions
bot
added
Dashboard
MananTank
requested review from
gregfromstl,
jnsdls and
joaquim-verges
as code owners
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5397 +/- ##
==========================================
+ Coverage 45.52% 45.53% +0.01%
==========================================
Files 1070 1070
Lines 55665 55671 +6
Branches 4030 4032 +2
==========================================
+ Hits 25341 25350 +9
+ Misses 29637 29633 -4
- Partials 687 688 +1
*This pull request uses carry forward flags. Click here to find out more.
|
jnsdls
approved these changes
Nov 12, 2024
Contributor
Merge activity
|
MananTank
added a commit
that referenced
this pull request
Nov 12, 2024
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on enhancing error handling for `localStorage` operations across various components, ensuring that unhandled errors do not disrupt functionality.
### Detailed summary
- Wrapped `localStorage.setItem` and `localStorage.getItem` calls in `try-catch` blocks to handle potential errors.
- Updated `ThemeSwitcher`, `RightSection`, `useLocalStorage`, `Banner`, and `webLocalStorage` to ignore errors gracefully.
- Maintained existing functionality while improving robustness.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
MananTank
force-pushed
the
11-12-catch_localstorage_getitem_and_setitem_unhandled_errors
branch
from
8bbdbb0 to
4c95ee3
Compare
MananTank
added a commit
that referenced
this pull request
Nov 13, 2024
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on enhancing error handling for `localStorage` operations across various components, ensuring that unhandled errors do not disrupt functionality.
### Detailed summary
- Wrapped `localStorage.setItem` and `localStorage.getItem` calls in `try-catch` blocks to handle potential errors.
- Updated `ThemeSwitcher`, `RightSection`, `useLocalStorage`, `Banner`, and `webLocalStorage` to ignore errors gracefully.
- Maintained existing functionality while improving robustness.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
MananTank
force-pushed
the
11-12-catch_localstorage_getitem_and_setitem_unhandled_errors
branch
from
4c95ee3 to
7d8a1af
Compare
gregfromstl
changed the title
gregfromstl
added
the
merge-queue
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on enhancing error handling for `localStorage` operations across various components, ensuring that unhandled errors do not disrupt functionality.
### Detailed summary
- Wrapped `localStorage.setItem` and `localStorage.getItem` calls in `try-catch` blocks to handle potential errors.
- Updated `ThemeSwitcher`, `RightSection`, `useLocalStorage`, `Banner`, and `webLocalStorage` to ignore errors gracefully.
- Maintained existing functionality while improving robustness.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
MananTank
force-pushed
the
11-12-catch_localstorage_getitem_and_setitem_unhandled_errors
branch
from
7d8a1af to
895b4d1
Compare
graphite-app
bot
deleted the
11-12-catch_localstorage_getitem_and_setitem_unhandled_errors
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on adding error handling for
localStorageoperations across various components and hooks, ensuring that unhandled errors do not disrupt the application's functionality.Detailed summary
localStorage.setItemandlocalStorage.getItemcalls intry-catchblocks to handle potential errors gracefully.ThemeSwitcher.tsx,RightSection.tsx,useLocalStorage.ts,Banner.tsx, andwebStorage.tswith error handling logic.localStoragefailures.