[Dashboard] Feature: Updated Mintable Modules #5404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GWSzeto
requested review from
MananTank,
gregfromstl,
jnsdls and
joaquim-verges
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
packages/thirdweb/src/extensions/modules/MintableERC1155/mintWithRole.ts
Outdated
Show resolved
Hide resolved
Contributor
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5404 +/- ##
==========================================
- Coverage 45.53% 45.52% -0.01%
==========================================
Files 1070 1070
Lines 55709 55715 +6
Branches 4031 4031
==========================================
+ Hits 25365 25367 +2
- Misses 29657 29661 +4
Partials 687 687
*This pull request uses carry forward flags. Click here to find out more.
|
gregfromstl
changed the title
Contributor
|
@GWSzeto is there an eng linear ticket for this? The one linked is under design and marked as completed. Sorry for being strict about this it just helps give context so we can review |
MananTank
reviewed
Nov 13, 2024
...ard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/modules/components/Mintable.tsx
Outdated
Show resolved
Hide resolved
MananTank
reviewed
Nov 13, 2024
packages/thirdweb/src/extensions/modules/MintableERC1155/mintWithRole.ts
Outdated
Show resolved
Hide resolved
MananTank
approved these changes
Nov 14, 2024
gregfromstl
approved these changes
Nov 19, 2024
Contributor
Author
Merge activity
|
https://linear.app/thirdweb/project/[modular-contracts]-modules-ui-c7a2be28299d/overview <!-- start pr-codex --> ## PR-Codex overview This PR focuses on enhancing the `Mintable` functionality in the dashboard and improving the handling of URIs in the `MintableERC721` and `MintableERC1155` modules. It also refines role management for minting processes. ### Detailed summary - Changed the condition in `module-instance.tsx` to check for "Mintable" instead of "Mintable-ignore". - Updated `mintWithRole.ts` in both `MintableERC721` and `MintableERC1155` to conditionally process `nfts` and set `baseURI`. - Simplified import statements in `Mintable.tsx`. - Modified `hasMinterRole` and `grantRoleTx` to use a more concise syntax for role checking and granting in `Mintable.tsx`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
GWSzeto
force-pushed
the
mintable-module-ui
branch
from
b4dff16 to
55edd4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/thirdweb/project/[modular-contracts]-modules-ui-c7a2be28299d/overview
PR-Codex overview
This PR focuses on improving the handling of mintable modules in the dashboard and thirdweb packages, specifically refining the conditions for checking roles and optimizing the URI handling for NFTs.
Detailed summary
module-instance.tsxto check for "Mintable" instead of "Mintable-ignore".mintWithRole.tsfor bothMintableERC721andMintableERC1155to check if NFTs are not empty before processing.hasAllRolesandgrantRolesinMintable.tsxfor better role management.