Skip to content

[Dashboard] Feature: Adds github as a login option #5411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2024
Merged

[Dashboard] Feature: Adds github as a login option #5411

merged 1 commit into from
Nov 13, 2024

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Nov 13, 2024 •
edited by pr-codex bot
Loading

CNCT-2357

PR-Codex overview

This PR adds wallet integration options to the LoginPage component, allowing users to connect through various wallets, including in-app options and specific wallet providers.

Detailed summary

  • Imported createWallet and inAppWallet from thirdweb/wallets.
  • Defined a wallets array with multiple wallet options including in-app authentication methods (Google, Apple, etc.) and external wallets (MetaMask, Coinbase, etc.).
  • Passed the wallets array to the CustomConnectEmmbed component.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl added the Dashboard Involves changes to the Dashboard. label Nov 13, 2024
@gregfromstl gregfromstl self-assigned this Nov 13, 2024
@linear
Copy link

linear bot commented Nov 13, 2024

CNCT-2357 Add Github as login method in dashboard

@vercel
Copy link

vercel bot commented Nov 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 8:26pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 13, 2024 8:26pm
thirdweb_playground ⬜️ Skipped (Inspect) Nov 13, 2024 8:26pm
wallet-ui ⬜️ Skipped (Inspect) Nov 13, 2024 8:26pm

@changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9f9b67d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 13, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@codecov
Copy link

codecov bot commented Nov 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.52%. Comparing base (24a53e3) to head (9f9b67d).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5411   +/-   ##
=======================================
  Coverage   45.52%   45.52%           
=======================================
  Files        1070     1070           
  Lines       55665    55665           
  Branches     4030     4030           
=======================================
  Hits        25341    25341           
  Misses      29637    29637           
  Partials      687      687
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 24a53e3
packages 40.62% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.8 KB (0%) 896 ms (0%) 214 ms (+99.64% 🔺) 1.2 s
thirdweb (cjs) 105.11 KB (0%) 2.2 s (0%) 295 ms (+55.05% 🔺) 2.4 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 50 ms (+478.68% 🔺) 164 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 70 ms (+3889.36% 🔺) 80 ms
thirdweb/react (minimal + tree-shaking) 18.78 KB (0%) 376 ms (0%) 163 ms (+736.54% 🔺) 539 ms

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 13, 2024
@gregfromstl Graphite App
Copy link
Contributor Author

gregfromstl commented Nov 13, 2024 •
edited by graphite-app bot
Loading

Merge activity

  • Nov 13, 3:13 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 13, 3:13 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 13, 3:28 PM EST: A user merged this pull request with the Graphite merge queue.

@gregfromstl
[Dashboard] Feature: Adds github as a login option (#5411)
9f9b67d 
CNCT-2357

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces wallet integration into the login functionality of the application, allowing users to connect using various wallet options.

### Detailed summary
- Added wallet integration by importing `createWallet` and `inAppWallet` from `thirdweb/wallets`.
- Defined a `wallets` array containing multiple wallet options including `inAppWallet` and various `createWallet` instances.
- Updated the `CustomConnectEmbed` component to utilize the new `wallets` array for authentication.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@gregfromstl gregfromstl force-pushed the greg/cnct-2357-add-github-as-login-method-in-dashboard branch from 7bd69b6 to 9f9b67d Compare November 13, 2024 20:14
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 13, 2024 20:14 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 13, 2024 20:14 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 13, 2024 20:14 Inactive
@graphite-app graphite-app bot merged commit 9f9b67d into main Nov 13, 2024
32 checks passed
@graphite-app graphite-app bot deleted the greg/cnct-2357-add-github-as-login-method-in-dashboard branch November 13, 2024 20:28
@vercel vercel bot temporarily deployed to Production – wallet-ui November 13, 2024 20:28 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 November 13, 2024 20:28 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 13, 2024 20:28 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

@MananTank MananTank Awaiting requested review from MananTank

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

@gregfromstl gregfromstl

Labels

Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gregfromstl @jnsdls