Skip to content

[CI] Chore: Update PR stale time to 7 days #5417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2024
Merged

[CI] Chore: Update PR stale time to 7 days #5417

merged 1 commit into from
Nov 14, 2024

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Nov 14, 2024 •
edited by pr-codex bot
Loading

CNCT-2336

PR-Codex overview

This PR updates the configuration for stale issues and pull requests in the .github/workflows/stale.yml file, reducing the inactivity periods before marking them as stale and before closing them.

Detailed summary

  • Changed days-before-stale from 30 to 7 days.
  • Changed days-before-close from 5 to 2 days.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Nov 14, 2024

CNCT-2336 Reduce Stale PR Time to 7 Days

@vercel
Copy link

vercel bot commented Nov 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 6:01am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 6:01am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 6:01am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 6:01am

@changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2024

⚠️ No Changeset found

Latest commit: 26bdd76

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gregfromstl gregfromstl self-assigned this Nov 14, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 14, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@codecov
Copy link

codecov bot commented Nov 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.52%. Comparing base (c93755e) to head (3488281).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5417   +/-   ##
=======================================
  Coverage   45.52%   45.52%           
=======================================
  Files        1070     1070           
  Lines       55665    55665           
  Branches     4030     4030           
=======================================
  Hits        25341    25341           
  Misses      29637    29637           
  Partials      687      687
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from c93755e
packages 40.62% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.8 KB (0%) 896 ms (0%) 5.4 s (+65.61% 🔺) 6.3 s
thirdweb (cjs) 105.11 KB (0%) 2.2 s (0%) 7 s (-9.03% 🔽) 9.1 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 660 ms (+131.81% 🔺) 775 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 197 ms (-10.31% 🔽) 207 ms
thirdweb/react (minimal + tree-shaking) 18.78 KB (0%) 376 ms (0%) 798 ms (+19.04% 🔺) 1.2 s

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 14, 2024
@gregfromstl Graphite App
Copy link
Contributor Author

gregfromstl commented Nov 14, 2024 •
edited by graphite-app bot
Loading

Merge activity

  • Nov 13, 7:53 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 14, 12:55 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 14, 12:59 AM EST: A user merged this pull request with the Graphite merge queue.

@gregfromstl
[CI] Chore: Update PR stale time to 7 days (#5417)
3488281 
CNCT-2336

<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates the configuration for stale issues and pull requests in the `.github/workflows/stale.yml` file, reducing the inactivity duration before marking them as stale and the time before they are closed.

### Detailed summary
- Changed `days-before-stale` from 30 to 7.
- Changed `days-before-close` from 5 to 2.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@gregfromstl gregfromstl force-pushed the greg/cnct-2336-reduce-stale-pr-time-to-7-days branch from 26bdd76 to 3488281 Compare November 14, 2024 05:56
@graphite-app graphite-app bot merged commit 3488281 into main Nov 14, 2024
30 of 31 checks passed
@graphite-app graphite-app bot deleted the greg/cnct-2336-reduce-stale-pr-time-to-7-days branch November 14, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges joaquim-verges is a code owner

Assignees

@gregfromstl gregfromstl

Labels

merge-queue Adds the pull request to Graphite's merge queue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gregfromstl @jnsdls