Skip to content

fix: transferable module restriction #5420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2024
Merged

fix: transferable module restriction #5420

merged 1 commit into from
Nov 14, 2024

Conversation

@GWSzeto
Copy link
Contributor

@GWSzeto GWSzeto commented Nov 14, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on updating the isRestricted prop in the Transferable component to invert its boolean logic based on the isTransferEnabledQuery.data.

Detailed summary

  • Changed the isRestricted prop from isRestricted={!!isTransferEnabledQuery.data} to isRestricted={!isTransferEnabledQuery.data}.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 6:40pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 14, 2024 6:40pm
thirdweb_playground ⬜️ Skipped (Inspect) Nov 14, 2024 6:40pm
wallet-ui ⬜️ Skipped (Inspect) Nov 14, 2024 6:40pm

@changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5218313

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 14, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 14, 2024
@GWSzeto GWSzeto force-pushed the transferable-fix-enabled branch from 4a8746b to 6fd51a9 Compare November 14, 2024 16:47
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 14, 2024 16:47 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 14, 2024 16:47 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 14, 2024 16:47 Inactive
@codecov
Copy link

codecov bot commented Nov 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.52%. Comparing base (731089b) to head (5218313).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5420   +/-   ##
=======================================
  Coverage   45.52%   45.52%           
=======================================
  Files        1070     1070           
  Lines       55665    55665           
  Branches     4030     4030           
=======================================
  Hits        25341    25341           
  Misses      29637    29637           
  Partials      687      687
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 731089b
packages 40.62% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.8 KB (0%) 896 ms (0%) 172 ms (+7.79% 🔺) 1.1 s
thirdweb (cjs) 105.11 KB (0%) 2.2 s (0%) 380 ms (+17.17% 🔺) 2.5 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 85 ms (+919.33% 🔺) 200 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 27 ms (+780.54% 🔺) 37 ms
thirdweb/react (minimal + tree-shaking) 18.78 KB (0%) 376 ms (0%) 121 ms (+416.73% 🔺) 497 ms

@MananTank MananTank changed the title fix: transferable fix fix: transferable module restriction Nov 14, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 14, 2024 •
edited
Loading

Merge activity

@GWSzeto
fix: transferable module restriction (#5420)
5218313 
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on modifying the `isRestricted` prop in the `Transferable` component to invert its boolean value based on the `isTransferEnabledQuery.data`.

### Detailed summary
- Changed the `isRestricted` prop from `isRestricted={!!isTransferEnabledQuery.data}` to `isRestricted={!isTransferEnabledQuery.data}`.
- Other props remain unchanged, including `isPending`, `adminAddress`, `update`, and `isOwnerAccount`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the transferable-fix-enabled branch from 6fd51a9 to 5218313 Compare November 14, 2024 18:31
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 14, 2024 18:31 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 14, 2024 18:31 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 14, 2024 18:31 Inactive
@GWSzeto GWSzeto added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 14, 2024
@graphite-app graphite-app bot merged commit 5218313 into main Nov 14, 2024
31 of 32 checks passed
@graphite-app graphite-app bot deleted the transferable-fix-enabled branch November 14, 2024 18:41
@vercel vercel bot temporarily deployed to Production – docs-v2 November 14, 2024 18:41 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 14, 2024 18:41 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui November 14, 2024 18:41 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MananTank MananTank MananTank approved these changes

@jnsdls jnsdls Awaiting requested review from jnsdls

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GWSzeto @MananTank