Skip to content

Fix claim condition form loading state #5421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2024
Merged

Fix claim condition form loading state #5421

merged 1 commit into from
Nov 14, 2024

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Nov 14, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR updates the condition for rendering a loading state in the claim-conditions-form component. It replaces the previous check for isFetchingData with a check for claimConditionsQuery.isPending.

Detailed summary

  • Changed the conditional check from isFetchingData to claimConditionsQuery.isPending for rendering logic.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 731089b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui November 14, 2024 17:12 Inactive
@vercel
Copy link

vercel bot commented Nov 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 6:29pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 14, 2024 6:29pm
thirdweb_playground ⬜️ Skipped (Inspect) Nov 14, 2024 6:29pm
wallet-ui ⬜️ Skipped (Inspect) Nov 14, 2024 6:29pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 14, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 14, 2024 17:12 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 14, 2024 17:12 Inactive
@MananTank MananTank marked this pull request as ready for review November 14, 2024 17:12
@MananTank Graphite App
Copy link
Member Author

MananTank commented Nov 14, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 14, 2024
@MananTank MananTank added the hotfix This pull request should be prioritized in the merge queue. label Nov 14, 2024 — with Graphite App
@MananTank Graphite App
Copy link
Member Author

MananTank commented Nov 14, 2024 •
edited by graphite-app bot
Loading

Merge activity

  • Nov 14, 12:12 PM EST: The merge label 'hotfix' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 14, 1:11 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 14, 1:30 PM EST: A user merged this pull request with the Graphite merge queue.

@codecov
Copy link

codecov bot commented Nov 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.52%. Comparing base (92e55c8) to head (731089b).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5421   +/-   ##
=======================================
  Coverage   45.52%   45.52%           
=======================================
  Files        1070     1070           
  Lines       55665    55665           
  Branches     4030     4030           
=======================================
  Hits        25341    25341           
  Misses      29637    29637           
  Partials      687      687
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 92e55c8
packages 40.62% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.8 KB (0%) 896 ms (0%) 306 ms (+162.01% 🔺) 1.3 s
thirdweb (cjs) 105.11 KB (0%) 2.2 s (0%) 328 ms (+37.83% 🔺) 2.5 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 107 ms (+1211.47% 🔺) 222 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 37 ms (+2098.79% 🔺) 47 ms
thirdweb/react (minimal + tree-shaking) 18.78 KB (0%) 376 ms (0%) 121 ms (+335% 🔺) 496 ms

@MananTank
Fix claim condition form loading state (#5421)
731089b 
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates the conditional rendering logic in the `claim-conditions-form` component to use `claimConditionsQuery.isPending` instead of `isFetchingData`, improving clarity on the loading state of the data.

### Detailed summary
- Changed the condition from `if (isFetchingData)` to `if (claimConditionsQuery.isPending)` in `index.tsx`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 11-14-fix_claim_condition_form_loading_state branch from 5af13e2 to 731089b Compare November 14, 2024 18:20
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 14, 2024 18:20 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 14, 2024 18:20 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 14, 2024 18:20 Inactive
@graphite-app graphite-app bot merged commit 731089b into main Nov 14, 2024
31 of 32 checks passed
@graphite-app graphite-app bot deleted the 11-14-fix_claim_condition_form_loading_state branch November 14, 2024 18:30
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 14, 2024 18:30 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui November 14, 2024 18:30 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 November 14, 2024 18:30 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard. hotfix This pull request should be prioritized in the merge queue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls