[SDK] Fix: Wallet avatar styles in ConnectButton and Modal #5422

kien-ngo · 2024-11-14T17:20:33Z

i just want my cat back

PR-Codex overview

This PR focuses on updating the styling of the img elements within the DetailsModal component to ensure they maintain their aspect ratio and fit correctly within their containers.

Detailed summary

Updated the style of the first img:
- Changed -width from "100%" to +width as "100%".
- Added +objectFit: "cover".
Updated the style of the second img:
- Changed -width from iconSize.xxl to +width as "100%".
- Changed -height from iconSize.xxl to +height as "100%".
- Added +objectFit: "cover".

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2024-11-14T17:20:37Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 18, 2024 8:13pm
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 18, 2024 8:13pm
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 18, 2024 8:13pm
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 18, 2024 8:13pm

changeset-bot · 2024-11-14T17:20:37Z

⚠️ No Changeset found

Latest commit: 510be22

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

graphite-app · 2024-11-14T17:20:39Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

kien-ngo · 2024-11-14T17:20:49Z

[SDK] Fix: Wallet avatar styles in ConnectButton and Modal #5422 👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2024-11-14T17:23:56Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	45.13 KB (0%)	903 ms (0%)	3 s (+49.02% 🔺)	3.9 s
thirdweb (cjs)	105.15 KB (0%)	2.2 s (0%)	6 s (-11.63% 🔽)	8.1 s
thirdweb (minimal + tree-shaking)	5.72 KB (0%)	115 ms (0%)	214 ms (-44.56% 🔽)	328 ms
thirdweb/chains (tree-shaking)	506 B (0%)	10 ms (0%)	52 ms (+39.62% 🔺)	62 ms
thirdweb/react (minimal + tree-shaking)	18.79 KB (0%)	376 ms (0%)	370 ms (+33.3% 🔺)	746 ms

codecov · 2024-11-15T03:36:09Z

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 45.52%. Comparing base (d4430d4) to head (510be22).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...hirdweb/src/react/web/ui/ConnectWallet/Details.tsx	0.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5422      +/-   ##
==========================================
- Coverage   45.52%   45.52%   -0.01%     
==========================================
  Files        1070     1070              
  Lines       55707    55709       +2     
  Branches     4031     4032       +1     
==========================================
  Hits        25361    25361              
- Misses      29659    29661       +2     
  Partials      687      687

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from d4430d4
packages	`40.63% <0.00%> (-0.01%)`	⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines	Coverage Δ
...hirdweb/src/react/web/ui/ConnectWallet/Details.tsx	`1.09% <0.00%> (-0.01%)`	⬇️

---- 🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

gregfromstl · 2024-11-15T23:08:39Z

Merge activity

Nov 15, 6:08 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Nov 15, 6:08 PM EST: A user added this pull request to the Graphite merge queue.
Nov 15, 7:00 PM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Vercel – thirdweb-www', 'check_linear_in_pr_body', 'codecov/patch/packages').
Nov 18, 2:21 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Nov 18, 2:40 PM EST: A user added this pull request to the Graphite merge queue.
Nov 18, 3:14 PM EST: A user merged this pull request with the Graphite merge queue.

i just want my cat back  --- ## PR-Codex overview This PR focuses on updating the styling of the `img` element in the `DetailsModal` component to ensure it covers the available space more effectively. ### Detailed summary - In the first `img` element: - Changed `-width: "100%"` to `+width: "100%"` - Added `+objectFit: "cover"` - In the second `img` element: - Changed `-width: iconSize.xxl` to `+width: "100%"` - Changed `-height: iconSize.xxl` to `+height: "100%"` - Added `+objectFit: "cover"` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

i just want my cat back  --- ## PR-Codex overview This PR focuses on updating the styling of the `img` elements within the `DetailsModal` component to ensure they maintain a consistent appearance and fit better within their containers. ### Detailed summary - Updated the `style` of the first `img` to include `width: "100%"` and `objectFit: "cover"`. - Modified the `style` of the second `img` to set `height: "100%"`, `width: "100%"`, and `objectFit: "cover"`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

i just want my cat back  --- ## PR-Codex overview This PR focuses on updating the styling of the `img` elements in the `DetailsModal` component to ensure they maintain aspect ratio and are responsive. ### Detailed summary - Changed the `width` of the first `img` to `"100%"` and added `objectFit: "cover"`. - Updated the second `img` to have `height` and `width` set to `"100%"`, along with `objectFit: "cover"`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

github-actions bot added the packages label Nov 14, 2024

kien-ngo marked this pull request as ready for review November 14, 2024 17:20

kien-ngo requested review from MananTank, edwardysun, gregfromstl, jnsdls and joaquim-verges as code owners November 14, 2024 17:20

vercel bot deployed to Preview – wallet-ui November 14, 2024 17:23 View deployment

vercel bot deployed to Preview – thirdweb_playground November 14, 2024 17:23 View deployment

vercel bot deployed to Preview – docs-v2 November 14, 2024 17:26 View deployment

vercel bot deployed to Preview – thirdweb-www November 14, 2024 17:33 View deployment

kien-ngo force-pushed the kien/fix-wallet-avatar branch from 944380a to 8a4b166 Compare November 14, 2024 17:36

vercel bot deployed to Preview – wallet-ui November 14, 2024 17:38 View deployment

vercel bot deployed to Preview – docs-v2 November 14, 2024 17:39 View deployment

vercel bot deployed to Preview – thirdweb_playground November 14, 2024 17:40 View deployment

vercel bot deployed to Preview – thirdweb-www November 14, 2024 17:45 View deployment

MananTank approved these changes Nov 14, 2024

View reviewed changes

kien-ngo force-pushed the kien/fix-wallet-avatar branch from 8a4b166 to e69bfd3 Compare November 15, 2024 03:30

vercel bot deployed to Preview – thirdweb_playground November 15, 2024 03:33 View deployment

vercel bot deployed to Preview – wallet-ui November 15, 2024 03:34 View deployment

vercel bot deployed to Preview – docs-v2 November 15, 2024 03:36 View deployment

vercel bot deployed to Preview – thirdweb-www November 15, 2024 03:40 View deployment

gregfromstl changed the title ~~[SDK] Fix wallet avatar in ConnectButton and Modal~~ [SDK] Fix: Wallet avatar styles in ConnectButton and Modal Nov 15, 2024

gregfromstl assigned kien-ngo Nov 15, 2024

gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 15, 2024

gregfromstl force-pushed the kien/fix-wallet-avatar branch from e69bfd3 to 8842ac7 Compare November 15, 2024 23:13

gregfromstl force-pushed the kien/fix-wallet-avatar branch from 8842ac7 to 19abf81 Compare November 15, 2024 23:17

vercel bot deployed to Preview – thirdweb_playground November 15, 2024 23:24 View deployment

vercel bot deployed to Preview – docs-v2 November 15, 2024 23:27 View deployment

vercel bot deployed to Preview – wallet-ui November 15, 2024 23:31 View deployment

vercel bot deployed to Preview – thirdweb-www November 15, 2024 23:59 View deployment

graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Nov 16, 2024

gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 18, 2024

gregfromstl force-pushed the kien/fix-wallet-avatar branch from 19abf81 to 510be22 Compare November 18, 2024 20:03

github-actions bot added the SDK Involves changes to the thirdweb SDK label Nov 18, 2024

vercel bot deployed to Preview – wallet-ui November 18, 2024 20:06 View deployment

vercel bot deployed to Preview – thirdweb_playground November 18, 2024 20:08 View deployment

vercel bot deployed to Preview – docs-v2 November 18, 2024 20:09 View deployment

vercel bot deployed to Preview – thirdweb-www November 18, 2024 20:13 View deployment

graphite-app bot merged commit 510be22 into main Nov 18, 2024
30 of 32 checks passed

graphite-app bot deleted the kien/fix-wallet-avatar branch November 18, 2024 20:14

vercel bot deployed to Production – thirdweb-www November 18, 2024 20:25 View deployment

vercel bot deployed to Production – wallet-ui November 18, 2024 20:31 View deployment

vercel bot deployed to Production – docs-v2 November 18, 2024 20:32 View deployment

vercel bot deployed to Production – thirdweb_playground November 18, 2024 20:33 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SDK] Fix: Wallet avatar styles in ConnectButton and Modal #5422

[SDK] Fix: Wallet avatar styles in ConnectButton and Modal #5422

Uh oh!

kien-ngo commented Nov 14, 2024 •

edited by pr-codex bot

Loading

Uh oh!

vercel bot commented Nov 14, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Nov 14, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Nov 14, 2024

Uh oh!

kien-ngo commented Nov 14, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Nov 14, 2024 •

edited

Loading

Uh oh!

codecov bot commented Nov 15, 2024 •

edited

Loading

Uh oh!

gregfromstl commented Nov 15, 2024 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[SDK] Fix: Wallet avatar styles in ConnectButton and Modal #5422

[SDK] Fix: Wallet avatar styles in ConnectButton and Modal #5422

Uh oh!

Conversation

kien-ngo commented Nov 14, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Uh oh!

vercel bot commented Nov 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Nov 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

graphite-app bot commented Nov 14, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

kien-ngo commented Nov 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

codecov bot commented Nov 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

gregfromstl commented Nov 15, 2024 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kien-ngo commented Nov 14, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Nov 14, 2024 •

edited

Loading

changeset-bot bot commented Nov 14, 2024 •

edited

Loading

kien-ngo commented Nov 14, 2024 •

edited

Loading

github-actions bot commented Nov 14, 2024 •

edited

Loading

codecov bot commented Nov 15, 2024 •

edited

Loading

gregfromstl commented Nov 15, 2024 •

edited by graphite-app bot

Loading