Skip to content

[Dashboard] Add gasless mint to zerion mint #5424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Dashboard] Add gasless mint to zerion mint #5424

wants to merge 1 commit into from

Conversation

@kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Nov 14, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR introduces support for gasless transactions in the NFT minting process by adding a gasless prop to relevant components and types.

Detailed summary

  • Added gasless prop to NftMint component.
  • Updated Props type in mint-ui.tsx to include optional gasless.
  • Included gasless option in DropPageData type.
  • Defined a sample gasless configuration in DROP_PAGES.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 3:33am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 15, 2024 3:33am
thirdweb_playground ⬜️ Skipped (Inspect) Nov 15, 2024 3:33am
wallet-ui ⬜️ Skipped (Inspect) Nov 15, 2024 3:33am

@vercel vercel bot temporarily deployed to Preview – docs-v2 November 14, 2024 19:24 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 14, 2024 19:24 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 14, 2024 19:24 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 34de2a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kien-ngo kien-ngo marked this pull request as ready for review November 14, 2024 19:25
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 14, 2024
@kien-ngo Graphite App
Copy link
Contributor Author

kien-ngo commented Nov 14, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kien-ngo kien-ngo force-pushed the kien/add-gasless-to-zerio branch from baa1309 to 2e68caa Compare November 14, 2024 19:25
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 14, 2024 19:26 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 14, 2024 19:26 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 14, 2024 19:26 Inactive
@codecov
Copy link

codecov bot commented Nov 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.50%. Comparing base (5de5c44) to head (34de2a3).
Report is 9 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5424      +/-   ##
==========================================
- Coverage   45.52%   45.50%   -0.02%     
==========================================
  Files        1070     1071       +1     
  Lines       55665    55718      +53     
  Branches     4030     4032       +2     
==========================================
+ Hits        25341    25357      +16     
- Misses      29637    29674      +37     
  Partials      687      687
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 5de5c44
packages 40.61% <ø> (-0.02%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 11 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.8 KB (0%) 896 ms (0%) 2.7 s (-11.16% 🔽) 3.6 s
thirdweb (cjs) 105.11 KB (0%) 2.2 s (0%) 5.6 s (+3.96% 🔺) 7.7 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 237 ms (+114.62% 🔺) 352 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 69 ms (+42.43% 🔺) 79 ms
thirdweb/react (minimal + tree-shaking) 18.79 KB (0%) 376 ms (0%) 686 ms (+14.87% 🔺) 1.1 s

@kien-ngo kien-ngo added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Nov 14, 2024 — with Graphite App
@kien-ngo kien-ngo force-pushed the kien/add-gasless-to-zerio branch from 2e68caa to 34de2a3 Compare November 15, 2024 03:24
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 15, 2024 03:24 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 15, 2024 03:24 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 15, 2024 03:24 Inactive
graphite-app[bot]
graphite-app bot reviewed Nov 15, 2024
View reviewed changes
apps/dashboard/src/app/drops/[slug]/data.ts
},
gasless: {
provider: "engine",
relayerForwarderAddress: "",
Copy link
Contributor

@graphite-app graphite-app bot Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The empty relayerForwarderAddress will prevent gasless transactions from working correctly. This field requires a valid contract address for the forwarder on the target network. Consider adding a network-specific forwarder address or removing the gasless configuration until the correct address is available.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

@kien-ngo kien-ngo closed this Nov 15, 2024
@kien-ngo kien-ngo deleted the kien/add-gasless-to-zerio branch November 15, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@jnsdls jnsdls Awaiting requested review from jnsdls

@MananTank MananTank Awaiting requested review from MananTank

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard. DO NOT MERGE This pull request is still in progress and is not ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kien-ngo