Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Nov 15, 2024

CNCT-2381


PR-Codex overview

This PR adds the export of a new utility function to enhance the contract deployment capabilities.

Detailed summary

  • Added export of prepareMethod from ../utils/abi/prepare-method.js to packages/thirdweb/src/exports/contract.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl added the Enhancement An improvement on existing functionality with no modifications to the public API. label Nov 15, 2024
@gregfromstl gregfromstl self-assigned this Nov 15, 2024
@linear
Copy link

linear bot commented Nov 15, 2024

@vercel
Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 8:00pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 8:00pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 8:00pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 8:00pm

@changeset-bot
Copy link

changeset-bot bot commented Nov 15, 2024

⚠️ No Changeset found

Latest commit: d4430d4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 15, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.13 KB (0%) 903 ms (0%) 713 ms (+25.82% 🔺) 1.7 s
thirdweb (cjs) 105.15 KB (0%) 2.2 s (0%) 1.3 s (+29.21% 🔺) 3.4 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 72 ms (+208.76% 🔺) 187 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 23 ms (+47.85% 🔺) 33 ms
thirdweb/react (minimal + tree-shaking) 18.79 KB (0%) 376 ms (0%) 163 ms (+65.28% 🔺) 539 ms

Copy link
Contributor Author

gregfromstl commented Nov 15, 2024

Merge activity

  • Nov 15, 6:37 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 16, 4:59 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 16, 5:11 AM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Vercel – thirdweb-www').
  • Nov 18, 2:08 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 18, 2:24 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 18, 3:01 PM EST: A user merged this pull request with the Graphite merge queue.

gregfromstl added a commit that referenced this pull request Nov 16, 2024
CNCT-2381

<!-- start pr-codex -->

---

## PR-Codex overview
This PR adds a new export to the `contract.ts` file, enhancing the functionality related to method preparation.

### Detailed summary
- Added export of `prepareMethod` from `../utils/abi/prepare-method.js` to `packages/thirdweb/src/exports/contract.ts`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@gregfromstl gregfromstl force-pushed the greg/cnct-2381-export-preparemethod branch from 6054194 to 7b7be4b Compare November 16, 2024 10:00
@codecov
Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.52%. Comparing base (ed58c4c) to head (d4430d4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5439   +/-   ##
=======================================
  Coverage   45.52%   45.52%           
=======================================
  Files        1070     1070           
  Lines       55707    55707           
  Branches     4032     4031    -1     
=======================================
  Hits        25361    25361           
  Misses      29659    29659           
  Partials      687      687           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from ed58c4c
packages 40.63% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

---- 🚨 Try these New Features:

@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Nov 16, 2024
@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 18, 2024
CNCT-2381

<!-- start pr-codex -->

---

## PR-Codex overview
This PR adds a new export to the `contract.ts` file, enhancing the available utilities for contract interactions.

### Detailed summary
- Added export for `prepareMethod` from `../utils/abi/prepare-method.js`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@gregfromstl gregfromstl force-pushed the greg/cnct-2381-export-preparemethod branch from 7b7be4b to d4430d4 Compare November 18, 2024 19:40
@github-actions github-actions bot added the SDK Involves changes to the thirdweb SDK label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement An improvement on existing functionality with no modifications to the public API. merge-queue Adds the pull request to Graphite's merge queue. packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants