[SDK] Fix useSetActiveWallet code example in JSDoc #5444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
MananTank
requested review from
edwardysun,
gregfromstl,
jnsdls and
joaquim-verges
as code owners
Contributor
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5444 +/- ##
=======================================
Coverage 45.52% 45.52%
=======================================
Files 1070 1070
Lines 55707 55707
Branches 4031 4032 +1
=======================================
Hits 25361 25361
Misses 29659 29659
Partials 687 687
*This pull request uses carry forward flags. Click here to find out more.
|
MananTank
changed the title
gregfromstl
added
the
merge-queue
gregfromstl
approved these changes
Nov 18, 2024
Contributor
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on renaming a variable for clarity in the `useSetActiveWallet` hook implementation within the `useSetActiveWallet.ts` file.
### Detailed summary
- Renamed the variable `setActiveAccount` to `setActiveWallet` for consistency with the hook name.
- Updated the usage of the variable to `await setActiveWallet(wallet);` to reflect the new name.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
MananTank
force-pushed
the
11-18-fix_usesetactivewallet_code_example_in_jsdoc
branch
from
3e1eb5e to
ed58c4c
Compare
graphite-app
bot
deleted the
11-18-fix_usesetactivewallet_code_example_in_jsdoc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on renaming the variable used to set the active wallet in the
useSetActiveWallethook for clarity and consistency.Detailed summary
setActiveAccounttosetActiveWalletfor better clarity.await setActiveAccount(account);toawait setActiveWallet(wallet);.