Skip to content

Add turbo defaults to inputs in turbo config #5454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2024
Merged

Add turbo defaults to inputs in turbo config #5454

merged 1 commit into from
Nov 18, 2024

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Nov 18, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR updates the turbo.json configuration to include a placeholder, $TURBO_DEFAULT$, in the inputs for several tasks, enhancing flexibility in input management.

Detailed summary

  • Added $TURBO_DEFAULT$ to inputs for:
    • thirdweb#update-version
    • test
    • storybook
    • test:legacy
    • e2e
    • e2e:legacy

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 10:29pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 10:29pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 10:29pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 10:29pm

@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: d7e36a8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 18, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@MananTank MananTank marked this pull request as ready for review November 18, 2024 22:05
@MananTank Graphite App
Copy link
Member Author

MananTank commented Nov 18, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.9 KB (0%) 899 ms (0%) 394 ms (-6.56% 🔽) 1.3 s
thirdweb (cjs) 105.02 KB (0%) 2.2 s (0%) 792 ms (-0.08% 🔽) 2.9 s
thirdweb (minimal + tree-shaking) 5.61 KB (0%) 113 ms (0%) 132 ms (+352.35% 🔺) 244 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 15 ms (-2.83% 🔽) 25 ms
thirdweb/react (minimal + tree-shaking) 18.41 KB (0%) 369 ms (0%) 60 ms (+2.93% 🔺) 428 ms

@codecov
Copy link

codecov bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.53%. Comparing base (bcbfb20) to head (d7e36a8).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5454   +/-   ##
=======================================
  Coverage   45.52%   45.53%           
=======================================
  Files        1070     1070           
  Lines       55709    55709           
  Branches     4032     4033    +1     
=======================================
+ Hits        25361    25366    +5     
+ Misses      29661    29656    -5     
  Partials      687      687
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from bcbfb20
packages 40.64% <ø> (+0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 2 files with indirect coverage changes

---- 🚨 Try these New Features:

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 18, 2024 •
edited
Loading

Merge activity

@MananTank
Add turbo defaults to inputs in turbo config (#5454)
d7e36a8 
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the `inputs` in various tasks defined in `turbo.json` to include a new variable `$TURBO_DEFAULT$`, enhancing the configuration for better management of dependencies.

### Detailed summary
- Updated `inputs` for `thirdweb#update-version` to include `$TURBO_DEFAULT$`.
- Modified `inputs` for `test`, `storybook`, `test:legacy`, `e2e`, and `e2e:legacy` to include `$TURBO_DEFAULT$`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 11-19-add_turbo_defaults_to_inputs_in_turbo_config branch from 3f38eb0 to d7e36a8 Compare November 18, 2024 22:18
@graphite-app graphite-app bot merged commit d7e36a8 into main Nov 18, 2024
31 of 32 checks passed
@graphite-app graphite-app bot deleted the 11-19-add_turbo_defaults_to_inputs_in_turbo_config branch November 18, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges joaquim-verges is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls