Skip to content

[Dashboard] Redirect /solutions/chains to /solutions/ecosystem #5486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2024
Merged

[Dashboard] Redirect /solutions/chains to /solutions/ecosystem #5486

merged 1 commit into from
Nov 22, 2024

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Nov 21, 2024 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on removing the chains.tsx file, updating redirects related to solutions, and modifying the page-id.ts file to reflect changes in solution pages.

Detailed summary

  • Deleted apps/dashboard/src/pages/solutions/chains.tsx.
  • Deleted apps/dashboard/src/components/landing-pages/plan.tsx.
  • Updated framer-rewrites.js to include /solutions/ecosystem.
  • Added redirect from /solutions/chains to /solutions/ecosystem in redirects.js.
  • Removed SolutionsChains identifier from page-id.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: d98c133

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 0:20am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 22, 2024 0:20am
thirdweb_playground ⬜️ Skipped (Inspect) Nov 22, 2024 0:20am
wallet-ui ⬜️ Skipped (Inspect) Nov 22, 2024 0:20am

@vercel vercel bot temporarily deployed to Preview – docs-v2 November 21, 2024 23:28 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 21, 2024 23:28 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 21, 2024 23:28 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 21, 2024
@jnsdls Graphite App
Copy link
Member Author

jnsdls commented Nov 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls marked this pull request as ready for review November 21, 2024 23:29
@codecov
Copy link

codecov bot commented Nov 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.86%. Comparing base (63c5277) to head (d98c133).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5486   +/-   ##
=======================================
  Coverage   43.86%   43.86%           
=======================================
  Files        1076     1076           
  Lines       55972    55972           
  Branches     3910     3910           
=======================================
  Hits        24551    24551           
  Misses      30738    30738           
  Partials      683      683
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 63c5277
packages 38.59% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

---- 🚨 Try these New Features:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.97 KB (0%) 900 ms (0%) 285 ms (+21.02% 🔺) 1.2 s
thirdweb (cjs) 105.01 KB (0%) 2.2 s (0%) 951 ms (+54.48% 🔺) 3.1 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 33 ms (+93.03% 🔺) 145 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 7 ms (+2.15% 🔺) 17 ms
thirdweb/react (minimal + tree-shaking) 18.38 KB (0%) 368 ms (0%) 143 ms (+78.88% 🔺) 511 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 22, 2024 •
edited
Loading

Merge activity

@jnsdls jnsdls force-pushed the _Dashboard_Redirect_/solutions/chains_to_/solutions/ecosystem branch from 28ed0ae to d98c133 Compare November 22, 2024 00:12
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 22, 2024 00:12 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 22, 2024 00:12 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 22, 2024 00:12 Inactive
@graphite-app graphite-app bot merged commit d98c133 into main Nov 22, 2024
32 checks passed
@graphite-app graphite-app bot deleted the _Dashboard_Redirect_/solutions/chains_to_/solutions/ecosystem branch November 22, 2024 00:21
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 22, 2024 00:21 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 November 22, 2024 00:21 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui November 22, 2024 00:21 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquim-verges joaquim-verges joaquim-verges approved these changes

@MananTank MananTank Awaiting requested review from MananTank

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jnsdls @joaquim-verges