Skip to content

feat: Add warning for rejected sponsorship policies #5577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2024
Merged

feat: Add warning for rejected sponsorship policies #5577

merged 1 commit into from
Dec 3, 2024

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Dec 2, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR introduces a warning mechanism in the paymaster.ts file to alert users when a sponsorship policy rejects a transaction.

Detailed summary

  • Added a warning log when a transaction is rejected due to a sponsorship policy.
  • The log includes the reason for rejection and the associated policyId.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Dec 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 2:25am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 2:25am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 2:25am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 2:25am

@changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: e26f94f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 2, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@joaquim-verges joaquim-verges marked this pull request as ready for review December 2, 2024 20:41
@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Dec 2, 2024
@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Dec 2, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.92 KB (0%) 959 ms (0%) 502 ms (+7.1% 🔺) 1.5 s
thirdweb (cjs) 107.39 KB (0%) 2.2 s (0%) 874 ms (+58.65% 🔺) 3.1 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 120 ms (+409.35% 🔺) 232 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 6 ms (-45.87% 🔽) 16 ms
thirdweb/react (minimal + tree-shaking) 18.29 KB (0%) 366 ms (0%) 65 ms (+65.95% 🔺) 431 ms

@codecov
Copy link

codecov bot commented Dec 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 44.18%. Comparing base (c3d7b66) to head (e26f94f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ckages/thirdweb/src/wallets/smart/lib/paymaster.ts 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5577      +/-   ##
==========================================
+ Coverage   44.17%   44.18%   +0.01%     
==========================================
  Files        1083     1082       -1     
  Lines       56276    56253      -23     
  Branches     3975     3976       +1     
==========================================
- Hits        24858    24857       -1     
+ Misses      30735    30713      -22     
  Partials      683      683
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from c3d7b66
packages 39.03% <0.00%> (+0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...ckages/thirdweb/src/wallets/smart/lib/paymaster.ts 1.44% <0.00%> (-0.12%) ⬇️

... and 1 file with indirect coverage changes

@joaquim-verges joaquim-verges force-pushed the feat_Add_warning_for_rejected_sponsorship_policies branch from 5e2dd17 to e26f94f Compare December 3, 2024 02:04
jnsdls
jnsdls approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@jnsdls jnsdls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing lined linear issue

@joaquim-verges joaquim-verges merged commit b117cb1 into main Dec 3, 2024
30 of 32 checks passed
@joaquim-verges joaquim-verges deleted the feat_Add_warning_for_rejected_sponsorship_policies branch December 3, 2024 07:56
@jnsdls jnsdls mentioned this pull request Dec 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

@gregfromstl gregfromstl Awaiting requested review from gregfromstl

Assignees

No one assigned

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joaquim-verges @jnsdls