[SDK] Fix: Type wallet doesn't exists in getUser
#5593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElasticBottle
requested review from
gregfromstl,
jnsdls and
joaquim-verges
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 68ad62f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Contributor
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5593 +/- ##
==========================================
+ Coverage 44.19% 44.29% +0.10%
==========================================
Files 1082 1082
Lines 56253 56258 +5
Branches 3974 3990 +16
==========================================
+ Hits 24862 24921 +59
+ Misses 30708 30654 -54
Partials 683 683
*This pull request uses carry forward flags. Click here to find out more.
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
joaquim-verges
approved these changes
Dec 3, 2024
gregfromstl
changed the title
wallet doesn't exists in getUserwallet doesn't exists in getUser
ElasticBottle
added
the
merge-queue
Contributor
Author
Merge activity
|
ElasticBottle
added a commit
that referenced
this pull request
Dec 4, 2024
https://linear.app/thirdweb/issue/CNCT-2523/remapping-of-siwe-wallet-type-in-typescript-sdk <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the `getUser` function in the `Profiles` to align with TypeScript types and enhancing the test suite for `getUser` to cover various scenarios, including error handling and different query parameters. ### Detailed summary - Updated `type` in `getUser` to ensure it matches TypeScript types. - Enhanced `profiles` mapping to correctly categorize profile types. - Added tests for error scenarios when no secret key or query parameter is provided. - Implemented tests for fetching user data by email, phone, ID, and external wallet address. - Added handling for fetch errors and cases where no user is found. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
ElasticBottle
force-pushed
the
winston/cnct-2523-remapping-of-siwe-wallet-type-in-typescript-sdk
branch
from
a6d9c14 to
8c0607c
Compare
https://linear.app/thirdweb/issue/CNCT-2523/remapping-of-siwe-wallet-type-in-typescript-sdk <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the `getUser` function in the `Profiles` to align with TypeScript types and enhancing its test coverage. ### Detailed summary - Updated the `type` in `getUser` to correctly classify profile types as either "wallet" or their original type. - Added unit tests to handle various scenarios: missing secret key, missing query parameters, and handling fetch errors. - Verified correct API URL calls for different query parameters (email, phone, id, externalWalletAddress). - Included tests for fetching user profiles and handling cases where no user is found. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
ElasticBottle
force-pushed
the
winston/cnct-2523-remapping-of-siwe-wallet-type-in-typescript-sdk
branch
from
8c0607c to
68ad62f
Compare
graphite-app
bot
deleted the
winston/cnct-2523-remapping-of-siwe-wallet-type-in-typescript-sdk
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/thirdweb/issue/CNCT-2523/remapping-of-siwe-wallet-type-in-typescript-sdk
PR-Codex overview
This PR focuses on updating the
getUserfunction in theProfilesto align with TypeScript types, enhancing error handling, and adding tests for various user query scenarios.Detailed summary
typeingetUserto ensure it matches TypeScript types.profilesmapping to correctly set thetypebased on conditions.getUsercovering error cases and various query parameters (email, phone, id, externalWalletAddress).