Skip to content

feat: Support ERC6492 smart account signatures #5641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2024
Merged

feat: Support ERC6492 smart account signatures #5641

merged 1 commit into from
Dec 6, 2024

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Dec 6, 2024 •
edited by pr-codex bot
Loading

Problem solved

Fixes CNCT-2528

PR-Codex overview

This PR introduces support for ERC6492 within the thirdweb wallet framework, enhancing smart account signatures. It modifies various functions and tests to accommodate the new signature verification and message signing processes.

Detailed summary

  • Added ERC6492 support for smart account signatures.
  • Updated deployAndSignMessage and deployAndSignTypedData functions to handle factoryContract.
  • Replaced checkContractWalletSignature with verifyTypedData in tests.
  • Enhanced error handling in verifyHash function.
  • Added tests for signing messages and typed data.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Dec 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 2:18am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 2:18am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 2:18am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 2:18am

@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 59dbc8a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 6, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Dec 6, 2024
@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Dec 6, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@linear
Copy link

linear bot commented Dec 6, 2024

CNCT-2528 Support ERC-6492 for our smart account signing flow

@joaquim-verges joaquim-verges marked this pull request as ready for review December 6, 2024 01:30
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.72 KB (+0.03% 🔺) 915 ms (+0.03% 🔺) 873 ms (-16.93% 🔽) 1.8 s
thirdweb (cjs) 106.26 KB (+0.03% 🔺) 2.2 s (+0.03% 🔺) 2.4 s (+12.94% 🔺) 4.5 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 58 ms (-23.19% 🔽) 170 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 109 ms (+371.52% 🔺) 119 ms
thirdweb/react (minimal + tree-shaking) 18.74 KB (-0.17% 🔽) 375 ms (-0.17% 🔽) 229 ms (-56.4% 🔽) 603 ms

@codecov
Copy link

codecov bot commented Dec 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.76404% with 10 lines in your changes missing coverage. Please review.

Project coverage is 47.82%. Comparing base (5574c15) to head (59dbc8a).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
packages/thirdweb/src/wallets/smart/lib/signing.ts 88.09% 10 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5641      +/-   ##
==========================================
+ Coverage   47.80%   47.82%   +0.02%     
==========================================
  Files        1090     1088       -2     
  Lines       56691    56658      -33     
  Branches     4304     4306       +2     
==========================================
- Hits        27100    27096       -4     
+ Misses      28893    28864      -29     
  Partials      698      698
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 5574c15
packages 43.57% <88.76%> (+0.02%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
packages/thirdweb/src/auth/verify-hash.ts 70.78% <100.00%> (-3.08%) ⬇️
packages/thirdweb/src/wallets/smart/index.ts 56.31% <100.00%> (ø)
packages/thirdweb/src/wallets/smart/lib/signing.ts 87.07% <88.09%> (+1.27%) ⬆️

... and 3 files with indirect coverage changes

@joaquim-verges joaquim-verges force-pushed the feat_Support_ERC6492_smart_account_signatures branch from bb8808d to 59dbc8a Compare December 6, 2024 01:56
@joaquim-verges joaquim-verges merged commit d1716fc into main Dec 6, 2024
31 of 32 checks passed
@joaquim-verges joaquim-verges deleted the feat_Support_ERC6492_smart_account_signatures branch December 6, 2024 02:14
@jnsdls jnsdls mentioned this pull request Dec 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls Awaiting requested review from jnsdls

1 more reviewer

@gregfromstl gregfromstl gregfromstl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joaquim-verges @gregfromstl