[SDK] Fix: Custom auth profile label #5660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregfromstl
requested review from
MananTank,
edwardysun,
jnsdls and
joaquim-verges
as code owners
🦋 Changeset detectedLatest commit: 97357e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
gregfromstl
added
Bug
gregfromstl
force-pushed
the
greg/cnct-2607-fix-custom-auth-profile-label
branch
from
79464ba to
42796a7
Compare
Contributor
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5660 +/- ##
==========================================
+ Coverage 50.82% 51.22% +0.39%
==========================================
Files 1092 1092
Lines 57334 57336 +2
Branches 4636 4676 +40
==========================================
+ Hits 29142 29368 +226
+ Misses 27476 27252 -224
Partials 716 716
*This pull request uses carry forward flags. Click here to find out more.
|
joaquim-verges
approved these changes
Dec 10, 2024
gregfromstl
added
the
merge-queue
Contributor
Author
Merge activity
|
gregfromstl
added a commit
that referenced
this pull request
Dec 10, 2024
<!-- start pr-codex -->
## PR-Codex overview
This PR focuses on fixing the display of the "Custom Auth" profile type label in the `LinkedProfilesScreen` component and enhancing unit tests for various profile types.
### Detailed summary
- Updated `LinkedProfilesScreen.tsx` to return "Custom Profile" for `custom_auth_endpoint`.
- Added unit tests in `LinkedProfilesScreen.test.tsx` for:
- Email, Google, Phone, Wallet, Cognito profiles.
- Custom Auth profile type.
- Handling of unknown and guest profile types.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
gregfromstl
force-pushed
the
greg/cnct-2607-fix-custom-auth-profile-label
branch
from
42796a7 to
97357e4
Compare
<!-- start pr-codex -->
## PR-Codex overview
This PR focuses on improving the display of linked profiles in the `LinkedProfilesScreen` component by correctly handling the "Custom Auth" profile type and enhancing unit tests for various profile types.
### Detailed summary
- Updated the label for the "Custom Auth" profile type to "Custom Profile".
- Added unit tests for various profile types including email, google, phone, wallet address, cognito, custom_auth_endpoint, and unknown types.
- Ensured guest profiles are not displayed.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
gregfromstl
force-pushed
the
greg/cnct-2607-fix-custom-auth-profile-label
branch
from
97357e4 to
d5a68c8
Compare
graphite-app
bot
deleted the
greg/cnct-2607-fix-custom-auth-profile-label
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on updating the
LinkedProfilesScreencomponent to correctly display profile types, including a new label for "Custom Auth" profiles. It also enhances test coverage for different profile types.Detailed summary
LinkedProfilesScreen.tsxto return "Custom Profile" forcustom_auth_endpoint.LinkedProfilesScreen.test.tsxfor various profile types including email, google, phone, wallet, cognito, custom_auth_endpoint, and unknown.