add optional config to webhooks in engine #5817

nischitpra · 2024-12-20T00:37:29Z

PR-Codex overview

This PR focuses on enhancing webhook functionality by adding support for a new WEBHOOK_CONFIG feature, allowing users to provide configuration for webhooks in a structured format.

Detailed summary

Added "WEBHOOK_CONFIG" to the features list.
Introduced an optional config field in EngineWebhook and CreateWebhookInput.
Integrated useEngineSystemHealth to check for WEBHOOK_CONFIG support.
Updated AddWebhookButton to handle config input.
Modified WebhooksTable to display config if supported.
Enhanced DeleteWebhookModal and TestWebhookModal to show config if present.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

changeset-bot · 2024-12-20T00:37:33Z

⚠️ No Changeset found

Latest commit: f765214

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2024-12-20T00:37:34Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	❌ Failed (Inspect)			Dec 31, 2024 10:15am

3 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)	Dec 31, 2024 10:15am
thirdweb_playground	⬜️ Skipped (Inspect)	Dec 31, 2024 10:15am
wallet-ui	⬜️ Skipped (Inspect)	Dec 31, 2024 10:15am

graphite-app · 2024-12-20T00:37:36Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

...[team_slug]/(team)/~/engine/(instance)/[engineId]/webhooks/components/add-webhook-button.tsx

codecov · 2024-12-20T00:38:50Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.18%. Comparing base (fa26eef) to head (f765214).
Report is 360 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5817      +/-   ##
==========================================
+ Coverage   53.34%   55.18%   +1.83%     
==========================================
  Files        1101     1123      +22     
  Lines       59124    59611     +487     
  Branches     4825     5031     +206     
==========================================
+ Hits        31541    32895    +1354     
+ Misses      26864    25996     -868     
- Partials      719      720       +1

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from fa26eef
packages	`52.83% <ø> (+2.27%)`	⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 74 files with indirect coverage changes

github-actions · 2024-12-20T00:41:09Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	45.09 KB (+0.02% 🔺)	902 ms (+0.02% 🔺)	509 ms (-30.47% 🔽)	1.5 s
thirdweb (cjs)	110.84 KB (0%)	2.3 s (0%)	1.6 s (+21.11% 🔺)	3.8 s
thirdweb (minimal + tree-shaking)	5.58 KB (0%)	112 ms (0%)	109 ms (+62.85% 🔺)	220 ms
thirdweb/chains (tree-shaking)	506 B (0%)	10 ms (0%)	45 ms (+26.15% 🔺)	55 ms
thirdweb/react (minimal + tree-shaking)	19.12 KB (0%)	383 ms (0%)	355 ms (+34.78% 🔺)	738 ms

...[team_slug]/(team)/~/engine/(instance)/[engineId]/webhooks/components/add-webhook-button.tsx

github-actions · 2024-12-29T02:03:44Z

This PR has been inactive for 30 days. It is now marked as stale and will be closed in 5 days if no further activity occurs.

...[team_slug]/(team)/~/engine/(instance)/[engineId]/webhooks/components/add-webhook-button.tsx

arcoraven · 2024-12-31T11:17:46Z

...eam/[team_slug]/(team)/~/engine/(instance)/[engineId]/webhooks/components/webhooks-table.tsx

        title="webhooks"
        data={activeWebhooks}
-        columns={columns}
+        columns={columns || []}


Is columns ever falsy?

Yep, I had to move columns into a memo

arcoraven · 2024-12-31T11:25:40Z

apps/dashboard/src/@3rdweb-sdk/react/hooks/useEngine.ts

  | "HETEROGENEOUS_WALLET_TYPES"
-  | "SMART_BACKEND_WALLETS";
+  | "SMART_BACKEND_WALLETS"
+  | "WEBHOOK_CONFIG";


Are the webhook CRUD APIs backward compatible, as in if config is provided, an older Engine will just silently ignore it?

If so I'm debating if it's simpler to just show the config field for all Engines (and if anything make a small footnote that config is only used for low wallet balance alerts after Engine version v2.x.x).

Yeah old engine will not process the config as its not processed at all.

If we show it all engine, it could act as a nudge to upgrade the engine which is good I guess.

github-actions · 2025-01-08T01:58:37Z

This PR has been inactive for 7 days. It is now marked as stale and will be closed in 2 days if no further activity occurs.

github-actions · 2025-01-17T01:55:56Z

This PR has been inactive for 7 days. It is now marked as stale and will be closed in 2 days if no further activity occurs.

github-actions · 2025-02-06T01:57:35Z

This PR has been inactive for 7 days. It is now marked as stale and will be closed in 2 days if no further activity occurs.

github-actions · 2025-02-15T01:57:02Z

This PR has been inactive for 7 days. It is now marked as stale and will be closed in 2 days if no further activity occurs.

nischitpra assigned joaquim-verges and d4mr Dec 20, 2024

nischitpra requested review from a team and jakubkrehel as code owners December 20, 2024 00:37

github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 20, 2024

graphite-app bot reviewed Dec 20, 2024

View reviewed changes

...[team_slug]/(team)/~/engine/(instance)/[engineId]/webhooks/components/add-webhook-button.tsx Outdated Show resolved Hide resolved

vercel bot had a problem deploying to Preview – thirdweb-www December 20, 2024 00:40 Failure

nischitpra requested review from d4mr and joaquim-verges December 20, 2024 00:44

nischitpra unassigned joaquim-verges and d4mr Dec 20, 2024

vercel bot temporarily deployed to Preview – docs-v2 December 20, 2024 02:02 Inactive

vercel bot temporarily deployed to Preview – wallet-ui December 20, 2024 02:02 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground December 20, 2024 02:02 Inactive

graphite-app bot reviewed Dec 20, 2024

View reviewed changes

...[team_slug]/(team)/~/engine/(instance)/[engineId]/webhooks/components/add-webhook-button.tsx Outdated Show resolved Hide resolved

vercel bot had a problem deploying to Preview – thirdweb-www December 20, 2024 02:06 Failure

github-actions bot added the Stale label Dec 29, 2024

add optional config to webhooks in engine + backwards compatibility

f765214

nischitpra force-pushed the np/addWebhookConfig branch from 1e47014 to f765214 Compare December 31, 2024 09:29

vercel bot temporarily deployed to Preview – thirdweb_playground December 31, 2024 09:29 Inactive

vercel bot temporarily deployed to Preview – wallet-ui December 31, 2024 09:29 Inactive

vercel bot temporarily deployed to Preview – docs-v2 December 31, 2024 09:29 Inactive

graphite-app bot reviewed Dec 31, 2024

View reviewed changes

...[team_slug]/(team)/~/engine/(instance)/[engineId]/webhooks/components/add-webhook-button.tsx Show resolved Hide resolved

nischitpra removed the Stale label Dec 31, 2024

nischitpra enabled auto-merge (squash) December 31, 2024 09:34

vercel bot had a problem deploying to Preview – thirdweb-www December 31, 2024 10:15 Failure

arcoraven reviewed Dec 31, 2024

View reviewed changes

github-actions bot added Stale and removed Stale labels Jan 8, 2025

github-actions bot added Stale and removed Stale labels Jan 17, 2025

MananTank marked this pull request as draft January 22, 2025 19:22

auto-merge was automatically disabled January 22, 2025 19:22
Pull request was converted to draft

jnsdls force-pushed the main branch from ebb3dcd to 073b25a Compare January 29, 2025 19:27

github-actions bot added Stale and removed Stale labels Feb 6, 2025

github-actions bot added the Stale label Feb 15, 2025

github-actions bot closed this Feb 17, 2025

add optional config to webhooks in engine #5817

add optional config to webhooks in engine #5817

Conversation

nischitpra commented Dec 20, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Uh oh!

changeset-bot bot commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

vercel bot commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Dec 20, 2024

How to use the Graphite Merge Queue

Uh oh!

Uh oh!

codecov bot commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

Uh oh!

github-actions bot commented Dec 29, 2024

Uh oh!

Uh oh!

arcoraven Dec 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nischitpra Dec 31, 2024

Choose a reason for hiding this comment

Uh oh!

arcoraven Dec 31, 2024

Choose a reason for hiding this comment

Uh oh!

nischitpra Dec 31, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 8, 2025

Uh oh!

github-actions bot commented Jan 17, 2025

Uh oh!

github-actions bot commented Feb 6, 2025

Uh oh!

github-actions bot commented Feb 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nischitpra commented Dec 20, 2024 •

edited by pr-codex bot

Loading

changeset-bot bot commented Dec 20, 2024 •

edited

Loading

vercel bot commented Dec 20, 2024 •

edited

Loading

codecov bot commented Dec 20, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024 •

edited

Loading

arcoraven Dec 31, 2024 •

edited

Loading