Skip to content

Marketplace implementation addresses #5822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2024
Merged

Marketplace implementation addresses #5822

merged 1 commit into from
Dec 20, 2024

Conversation

@kumaryash90
Copy link
Member

@kumaryash90 kumaryash90 commented Dec 20, 2024 •
edited
Loading

TOOL-2813

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR introduces support for ZkSync chains by defining implementations and WETH addresses, updating contract deployment logic, and adding tests to ensure correct behavior for these chains.

Detailed summary

  • Added ZKSYNC_IMPLEMENTATIONS and ZKSYNC_WETH for ZkSync chain configurations.
  • Updated CustomContractForm to handle MarketplaceV3 for ZkSync chains.
  • Enhanced getAllDefaultConstructorParamsForImplementation to return WETH for ZkSync.
  • Introduced tests for retrieving implementations and default constructor parameters for ZkSync.
  • Modified getOrDeployInfraForPublishedContract to utilize ZkSync implementations.
  • Updated getOrDeployInfraContract to return WETH for ZkSync chains.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@kumaryash90 kumaryash90 requested review from a team and jakubkrehel as code owners December 20, 2024 14:53
@vercel
Copy link

vercel bot commented Dec 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 10:43pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 10:43pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 10:43pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 10:43pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 20, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. packages SDK Involves changes to the thirdweb SDK labels Dec 20, 2024
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 20, 2024 14:54 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 20, 2024 14:54 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 20, 2024 14:54 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.02 KB (0%) 901 ms (0%) 2.2 s (-3.7% 🔽) 3.1 s
thirdweb (cjs) 110.76 KB (0%) 2.3 s (0%) 5.8 s (+10.11% 🔺) 8 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 287 ms (-31.23% 🔽) 398 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 246 ms (+312.02% 🔺) 256 ms
thirdweb/react (minimal + tree-shaking) 19.1 KB (0%) 383 ms (0%) 650 ms (-17.75% 🔽) 1.1 s

@codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.55%. Comparing base (243c497) to head (3718020).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5822      +/-   ##
==========================================
+ Coverage   53.34%   53.55%   +0.20%     
==========================================
  Files        1101     1102       +1     
  Lines       59124    59163      +39     
  Branches     4825     4837      +12     
==========================================
+ Hits        31541    31685     +144     
+ Misses      26864    26760     -104     
+ Partials      719      718       -1
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 243c497
packages 50.82% <100.00%> (+0.25%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...hirdweb/src/contract/deployment/utils/bootstrap.ts 96.91% <100.00%> (+25.87%) ⬆️
.../src/contract/deployment/zksync/implementations.ts 100.00% <100.00%> (ø)
.../extensions/prebuilts/get-required-transactions.ts 62.70% <100.00%> (+2.26%) ⬆️

... and 8 files with indirect coverage changes

@changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3718020

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 December 20, 2024 16:35 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 20, 2024 16:35 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 20, 2024 16:35 Inactive
@kumaryash90 kumaryash90 added the merge-queue Adds the pull request to Graphite's merge queue. label Dec 20, 2024
@kumaryash90 Graphite App
Copy link
Member Author

kumaryash90 commented Dec 20, 2024 •
edited by graphite-app bot
Loading

Merge activity

  • Dec 20, 12:00 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 20, 5:40 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 20, 5:44 PM EST: A user merged this pull request with the Graphite merge queue.

@kumaryash90
Marketplace implementation addresses (#5822)
3718020 
TOOL-2814

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces support for `ZkSync` chains by adding implementations for contracts and adjusting methods to handle `ZkSync` specific logic, including fetching default constructor parameters and deploying contracts.

### Detailed summary
- Added `ZKSYNC_IMPLEMENTATIONS` and `ZKSYNC_WETH` records for various `ZkSync` chains.
- Updated `CustomContractForm` to handle `MarketplaceV3` differently for `ZkSync` chains.
- Introduced a test for retrieving default constructor parameters for `ZkSync`.
- Modified `getAllDefaultConstructorParamsForImplementation` to return `nativeTokenWrapper` for `ZkSync`.
- Updated contract deployment logic in `bootstrap.ts` to use `ZkSync` implementations.
- Added a test case for saving implementations for `ZkSync` chains.
- Enhanced contract fetching logic in `getOrDeployInfraContract` for `WETH9` on `ZkSync`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@kumaryash90 kumaryash90 force-pushed the yash/marketplace-impl-addresses branch from a3ff229 to 3718020 Compare December 20, 2024 22:40
@graphite-app graphite-app bot merged commit 3718020 into main Dec 20, 2024
32 checks passed
@graphite-app graphite-app bot deleted the yash/marketplace-impl-addresses branch December 20, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakeloo jakeloo jakeloo approved these changes

@jnsdls jnsdls jnsdls approved these changes

@jakubkrehel jakubkrehel Awaiting requested review from jakubkrehel

Assignees

@kumaryash90 kumaryash90

Labels

Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue. packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kumaryash90 @jakeloo @jnsdls