Skip to content

[Dashboard] fix: handle unreachable engine instances #6006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2025
Merged

[Dashboard] fix: handle unreachable engine instances #6006

merged 1 commit into from
Jan 21, 2025

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Jan 21, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on improving error handling for engine instance permissions in the layout.tsx and getEngineAccessPermission.ts files. It modifies how errors are returned and displayed to enhance user experience when accessing engine instances.

Detailed summary

  • In layout.tsx, the condition for displaying the error page for status 401 is separated from 500.
  • A new error page is returned for status 500 with a custom message.
  • In getEngineAccessPermission.ts, a try-catch block is added around the fetch call to handle potential errors.
  • In case of an error, it now returns an object with ok: false and status: 500.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: e026c94

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 21, 2025 00:51 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 21, 2025 00:51 Inactive
@vercel
Copy link

vercel bot commented Jan 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 1:05am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jan 21, 2025 1:05am
thirdweb_playground ⬜️ Skipped (Inspect) Jan 21, 2025 1:05am
wallet-ui ⬜️ Skipped (Inspect) Jan 21, 2025 1:05am

@vercel vercel bot temporarily deployed to Preview – docs-v2 January 21, 2025 00:51 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jan 21, 2025
@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Jan 21, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Jan 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.79%. Comparing base (89beb3c) to head (e026c94).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6006   +/-   ##
=======================================
  Coverage   54.79%   54.79%           
=======================================
  Files        1151     1151           
  Lines       61257    61257           
  Branches     5152     5152           
=======================================
  Hits        33565    33565           
  Misses      26964    26964           
  Partials      728      728
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 89beb3c
packages 52.44% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@joaquim-verges joaquim-verges changed the title [Dashboard] feat: Add Engine instance permission handling and UI components [Dashboard] fix: handle unreachable engine instances Jan 21, 2025
@joaquim-verges joaquim-verges marked this pull request as ready for review January 21, 2025 00:52
@joaquim-verges joaquim-verges requested review from a team as code owners January 21, 2025 00:52
@joaquim-verges joaquim-verges force-pushed the _Dashboard_feat_Add_Engine_instance_permission_handling_and_UI_components branch from aa5223f to e026c94 Compare January 21, 2025 00:53
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 21, 2025 00:53 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 21, 2025 00:53 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 21, 2025 00:53 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.66 KB (0%) 934 ms (0%) 3.4 s (-17.18% 🔽) 4.4 s
thirdweb (cjs) 116.84 KB (0%) 2.4 s (0%) 7.4 s (-2.22% 🔽) 9.8 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 551 ms (+1.09% 🔺) 663 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 156 ms (+225.6% 🔺) 166 ms
thirdweb/react (minimal + tree-shaking) 19.24 KB (0%) 385 ms (0%) 997 ms (+35.77% 🔺) 1.4 s

@joaquim-verges joaquim-verges merged commit 7d9986f into main Jan 21, 2025
30 of 32 checks passed
@joaquim-verges joaquim-verges deleted the _Dashboard_feat_Add_Engine_instance_permission_handling_and_UI_components branch January 21, 2025 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joaquim-verges joaquim-verges

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joaquim-verges