[TOOL-3231] Show View Project Link after creating a project in Modal #6055

MananTank · 2025-01-26T10:08:54Z

PR-Codex overview

This PR focuses on enhancing the handling of teamSlug in various components, particularly in the context of API key management and project interaction. It introduces new functionality for displaying project details and navigation based on the teamSlug value.

Detailed summary

Added teamSlug prop to several components, including CreateApiKeyModal, TeamProjectsPage, and TeamHeader.
Updated CreateAPIKeyDialogProps to include teamSlug.
Enhanced APIKeyDetails to fetch project information using teamSlug.
Introduced a "View Project" button that navigates to the project page if teamSlug is present.
Adjusted button text based on the presence of teamSlug.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

linear · 2025-01-26T10:08:56Z

TOOL-3231 Creating new project adds new project last in the list, resulting in being hidden behind pagination

vercel · 2025-01-26T10:08:57Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 27, 2025 9:55am

3 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)	Jan 27, 2025 9:55am
thirdweb_playground	⬜️ Skipped (Inspect)	Jan 27, 2025 9:55am
wallet-ui	⬜️ Skipped (Inspect)	Jan 27, 2025 9:55am

changeset-bot · 2025-01-26T10:08:58Z

⚠️ No Changeset found

Latest commit: d03e687

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

MananTank · 2025-01-26T10:09:14Z

[TOOL-3231] Show View Project Link after creating a project in Modal #6055 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-01-26T10:16:46Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	46.85 KB (0%)	938 ms (0%)	4.2 s (+50.63% 🔺)	5.2 s
thirdweb (cjs)	123.65 KB (0%)	2.5 s (0%)	9 s (-2.79% 🔽)	11.5 s
thirdweb (minimal + tree-shaking)	5.59 KB (0%)	112 ms (0%)	436 ms (+9.08% 🔺)	548 ms
thirdweb/chains (tree-shaking)	506 B (0%)	10 ms (0%)	129 ms (-12.25% 🔽)	139 ms
thirdweb/react (minimal + tree-shaking)	19.08 KB (0%)	382 ms (0%)	690 ms (-17.55% 🔽)	1.1 s

jnsdls

hm why not just redirect straight to it, feels like the logical step? also CI is failing

MananTank · 2025-01-26T18:38:30Z

Because we need to wait for user to copy the secret key

joaquim-verges

fixing the next version mismatch in my pr btw

codecov · 2025-01-27T09:51:42Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.01%. Comparing base (b6f189c) to head (d03e687).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6055      +/-   ##
==========================================
- Coverage   55.02%   55.01%   -0.01%     
==========================================
  Files        1152     1152              
  Lines       61280    61280              
  Branches     5181     5177       -4     
==========================================
- Hits        33722    33716       -6     
- Misses      26830    26834       +4     
- Partials      728      730       +2

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from b6f189c
packages	`52.71% <ø> (-0.02%)`	⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 4 files with indirect coverage changes

graphite-app · 2025-01-27T09:51:49Z

Merge activity

Jan 27, 4:51 AM EST: A user added this pull request to the Graphite merge queue.
Jan 27, 4:56 AM EST: A user merged this pull request with the Graphite merge queue.

…6055)  ## PR-Codex overview This PR introduces the `teamSlug` prop across multiple components to enhance API key management by associating it with specific teams. This allows for better project handling and user navigation within the dashboard. ### Detailed summary - Added `teamSlug` prop to `CreateAPIKeyModal` and related components. - Updated `embed-setup.tsx` to handle `teamSlug` as `undefined`. - Integrated `teamSlug` in `TeamProjectsPage` and `AccountHeader`. - Modified `CreateAPIKeyDialog` to include `teamSlug` in props. - Enhanced `APIKeyDetails` to fetch projects based on `teamSlug`. - Implemented conditional rendering for "View Project" button based on `teamSlug`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

vercel bot temporarily deployed to Preview – docs-v2 January 26, 2025 10:08 Inactive

vercel bot temporarily deployed to Preview – wallet-ui January 26, 2025 10:08 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground January 26, 2025 10:08 Inactive

github-actions bot assigned MananTank Jan 26, 2025

github-actions bot added the Dashboard Involves changes to the Dashboard. label Jan 26, 2025

MananTank marked this pull request as ready for review January 26, 2025 10:09

MananTank requested review from a team as code owners January 26, 2025 10:09

MananTank marked this pull request as draft January 26, 2025 10:11

MananTank marked this pull request as ready for review January 26, 2025 10:11

vercel bot deployed to Preview – thirdweb-www January 26, 2025 10:16 View deployment

jnsdls reviewed Jan 26, 2025

View reviewed changes

joaquim-verges approved these changes Jan 27, 2025

View reviewed changes

MananTank force-pushed the TOOL-3231 branch from 80831f2 to 12da100 Compare January 27, 2025 09:16

vercel bot temporarily deployed to Preview – docs-v2 January 27, 2025 09:16 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground January 27, 2025 09:16 Inactive

vercel bot temporarily deployed to Preview – wallet-ui January 27, 2025 09:16 Inactive

vercel bot deployed to Preview – thirdweb-www January 27, 2025 09:24 View deployment

MananTank force-pushed the TOOL-3231 branch from 12da100 to d03e687 Compare January 27, 2025 09:52

vercel bot temporarily deployed to Preview – wallet-ui January 27, 2025 09:52 Inactive

vercel bot temporarily deployed to Preview – docs-v2 January 27, 2025 09:52 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground January 27, 2025 09:52 Inactive

vercel bot deployed to Preview – thirdweb-www January 27, 2025 09:55 View deployment

graphite-app bot merged commit d03e687 into main Jan 27, 2025
31 checks passed

graphite-app bot deleted the TOOL-3231 branch January 27, 2025 09:56

vercel bot temporarily deployed to Production – thirdweb_playground January 27, 2025 09:56 Inactive

vercel bot temporarily deployed to Production – wallet-ui January 27, 2025 09:56 Inactive

vercel bot temporarily deployed to Production – docs-v2 January 27, 2025 09:56 Inactive

vercel bot deployed to Production – thirdweb-www January 27, 2025 10:04 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[TOOL-3231] Show View Project Link after creating a project in Modal #6055

[TOOL-3231] Show View Project Link after creating a project in Modal #6055

MananTank commented Jan 26, 2025 •

edited by pr-codex bot

Loading

Uh oh!

linear bot commented Jan 26, 2025

Uh oh!

vercel bot commented Jan 26, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Jan 26, 2025 •

edited

Loading

Uh oh!

MananTank commented Jan 26, 2025

Uh oh!

github-actions bot commented Jan 26, 2025 •

edited

Loading

Uh oh!

jnsdls left a comment

Uh oh!

MananTank commented Jan 26, 2025

Uh oh!

joaquim-verges left a comment

Uh oh!

codecov bot commented Jan 27, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Jan 27, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[TOOL-3231] Show View Project Link after creating a project in Modal #6055

[TOOL-3231] Show View Project Link after creating a project in Modal #6055

Conversation

MananTank commented Jan 26, 2025 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Uh oh!

linear bot commented Jan 26, 2025

Uh oh!

vercel bot commented Jan 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Jan 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

MananTank commented Jan 26, 2025

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Jan 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

jnsdls left a comment

Choose a reason for hiding this comment

Uh oh!

MananTank commented Jan 26, 2025

Uh oh!

joaquim-verges left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

graphite-app bot commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MananTank commented Jan 26, 2025 •

edited by pr-codex bot

Loading

vercel bot commented Jan 26, 2025 •

edited

Loading

changeset-bot bot commented Jan 26, 2025 •

edited

Loading

github-actions bot commented Jan 26, 2025 •

edited

Loading

codecov bot commented Jan 27, 2025 •

edited

Loading

graphite-app bot commented Jan 27, 2025 •

edited

Loading