Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Jan 28, 2025

closes: CORE-716


PR-Codex overview

This PR focuses on updating the thirdweb library and its dependencies, enhancing functionality with the addition of a randomPrivateKey export, and adjusting various test files and package versions.

Detailed summary

  • Added randomPrivateKey export from thirdweb/wallets.
  • Updated dependencies for @wagmi/core, @thirdweb-dev/service-utils, and others.
  • Adjusted test cases in ManageWalletScreen.test.tsx to skip certain tests.
  • Updated multiple package versions across the project.

The following files were skipped due to too many changes: pnpm-lock.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 7:01am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 7:01am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 7:01am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 7:01am

@changeset-bot
Copy link

changeset-bot bot commented Jan 28, 2025

🦋 Changeset detected

Latest commit: f2e6e94

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
thirdweb Patch
@thirdweb-dev/service-utils Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. Playground Changes involving the Playground codebase. Portal Involves changes to the Portal (docs) codebase. packages Ecosystem Portal Involves changes to the Ecosystem Portal SDK Involves changes to the thirdweb SDK labels Jan 28, 2025
Copy link
Member Author

jnsdls commented Jan 28, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@linear
Copy link

linear bot commented Jan 28, 2025

@jnsdls jnsdls marked this pull request as ready for review January 28, 2025 01:22
@jnsdls jnsdls requested review from a team as code owners January 28, 2025 01:22
@socket-security
Copy link

socket-security bot commented Jan 28, 2025

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@abstract-foundation/[email protected] 🔁 npm/@abstract-foundation/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +465 141 MB coffeexcoin
npm/@changesets/[email protected] 🔁 npm/@changesets/[email protected] Transitive: eval, unsafe +94 16.1 MB changesets-release-bot
npm/@chromatic-com/[email protected] 🔁 npm/@chromatic-com/[email protected] Transitive: filesystem +16 12.3 MB ghengeveld
npm/@cloudflare/[email protected] 🔁 npm/@cloudflare/[email protected] None 0 4.81 MB asapzacy, celso, cf-ci-write, ...32 more
npm/@next/[email protected] 🔁 npm/@next/[email protected] Transitive: environment, filesystem, network, shell +18 2.31 MB matt.straka, rauchg, timer, ...2 more
npm/@next/[email protected] 🔁 npm/@next/[email protected] Transitive: filesystem +18 589 kB matt.straka, rauchg, timer, ...2 more
npm/@next/[email protected] 🔁 npm/@next/[email protected] Transitive: filesystem, network +1 240 kB vercel-release-bot
npm/@playwright/[email protected] 🔁 npm/@playwright/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +2 11 MB dgozman-ms
npm/@radix-ui/[email protected] 🔁 npm/@radix-ui/[email protected] None +4 154 kB chancestrickland
npm/@radix-ui/[email protected] 🔁 npm/@radix-ui/[email protected] None +22 681 kB chancestrickland
npm/@radix-ui/[email protected] 🔁 npm/@radix-ui/[email protected] None +35 1.65 MB chancestrickland
npm/@radix-ui/[email protected] 🔁 npm/@radix-ui/[email protected] None +20 910 kB chancestrickland
npm/@radix-ui/[email protected] 🔁 npm/@radix-ui/[email protected] None +31 1.29 MB chancestrickland
npm/@radix-ui/[email protected] 🔁 npm/@radix-ui/[email protected] None +35 1.54 MB chancestrickland
npm/@radix-ui/[email protected] 🔁 npm/@radix-ui/[email protected] None +22 983 kB andy-hook, benoitgrelard, chancestrickland, ...3 more
npm/@sentry/[email protected] 🔁 npm/@sentry/[email protected] Transitive: eval, shell, unsafe +250 72.2 MB billyvg, evanpurkhiser, haza, ...7 more
npm/@shazow/[email protected] 🔁 npm/@shazow/[email protected] None +6 6.33 MB shazow
npm/@storybook/[email protected] 🔁 npm/@storybook/[email protected] Transitive: environment, eval, filesystem, unsafe +56 24.4 MB domyen, ghengeveld, jreinhold, ...9 more
npm/@storybook/[email protected] 🔁 npm/@storybook/[email protected] Transitive: environment +19 7.1 MB storybook-bot
npm/@storybook/[email protected] 🔁 npm/@storybook/[email protected] None +8 583 kB storybook-bot
npm/@storybook/[email protected] 🔁 npm/@storybook/[email protected] None 0 217 kB storybook-bot
npm/@storybook/[email protected] 🔁 npm/@storybook/[email protected] Transitive: eval, filesystem, network, shell, unsafe +512 45.8 MB storybook-bot
npm/@storybook/[email protected] 🔁 npm/@storybook/[email protected] Transitive: environment, eval, filesystem, shell, unsafe +80 15.1 MB storybook-bot
npm/@storybook/[email protected] 🔁 npm/@storybook/[email protected], npm/@storybook/[email protected] None +6 946 kB domyen, ghengeveld, jreinhold, ...9 more
npm/@storybook/[email protected] 🔁 npm/@storybook/[email protected] None +107 18.1 MB storybook-bot
npm/@tanstack/[email protected] 🔁 npm/@tanstack/[email protected] None +1 2.68 MB nksaraf, tannerlinsley
npm/@testing-library/[email protected] 🔁 npm/@testing-library/[email protected] Transitive: eval +22 4.01 MB brrianalexis, cmckinstry, dfcook, ...13 more
npm/@testing-library/[email protected] Transitive: environment, eval +22 4.11 MB brrianalexis, cmckinstry, dfcook, ...13 more
npm/@thirdweb-dev/[email protected] 🔁 npm/@thirdweb-dev/[email protected] None 0 1.41 MB thirdweb-bot
npm/@types/[email protected] 🔁 npm/@types/[email protected] None +1 2.05 MB types
npm/@types/[email protected] 🔁 npm/@types/[email protected] None 0 6.01 kB types
npm/@vercel/[email protected] 🔁 npm/@vercel/[email protected] None +23 16.9 MB chriswdmr, ijjk, matheuss, ...6 more
npm/@vitest/[email protected] 🔁 npm/@vitest/[email protected] Transitive: environment, filesystem, shell +57 10.5 MB antfu, oreanno, patak, ...1 more
npm/@vitest/[email protected] 🔁 npm/@vitest/[email protected] Transitive: environment, filesystem +14 2.28 MB vitestbot
npm/@walletconnect/[email protected] 🔁 npm/@walletconnect/[email protected] Transitive: environment, eval, filesystem, network, unsafe +183 36.5 MB gancho_walletconnect
npm/@walletconnect/[email protected] 🔁 npm/@walletconnect/[email protected] Transitive: environment, eval, filesystem, network, unsafe +126 24.1 MB gancho_walletconnect
npm/[email protected] 🔁 npm/[email protected] Transitive: environment, eval, filesystem, unsafe +172 15.7 MB timer, timneutkens, vercel-release-bot
npm/[email protected] 🔁 npm/[email protected] Transitive: filesystem +18 730 kB francoismassart
npm/[email protected] 🔁 npm/[email protected] Transitive: environment +3 3.12 MB alecmev-framer, andrey-framer, andrey.ozornin, ...51 more
npm/[email protected] 🔁 npm/[email protected] None +2 12.7 MB davidortner
npm/[email protected] 🔁 npm/[email protected] Transitive: filesystem, shell, unsafe +45 3.43 MB webpro
npm/[email protected] 🔁 npm/[email protected] None 0 34.7 MB ericfennis
npm/[email protected] 🔁 npm/[email protected] None +54 10.4 MB kettanaito
npm/[email protected] 🔁 npm/[email protected] None +13 124 MB rauchg, timneutkens, vercel-release-bot
npm/[email protected] 🔁 npm/[email protected] None +5 6.23 MB jmoxey
npm/[email protected] 🔁 npm/[email protected] None 0 263 kB mholt, pokoli
npm/[email protected] 🔁 npm/[email protected] None +39 11 MB ckifer
npm/[email protected] 🔁 npm/[email protected] None 0 268 kB emilkowalski
npm/[email protected] 🔁 npm/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +103 27.5 MB storybook-bot
npm/[email protected] 🔁 npm/[email protected] None 0 30 kB turbobot
npm/[email protected] 🔁 npm/[email protected] Transitive: environment, filesystem +18 16.1 MB typedoc-bot
npm/[email protected] 🔁 npm/[email protected] None 0 22.7 MB typescript-bot
npm/[email protected] 🔁 npm/[email protected] Transitive: filesystem, shell, unsafe +33 4.41 MB antfu, oreanno, patak, ...1 more

🚮 Removed packages: npm/@noble/[email protected], npm/@noble/[email protected], npm/@types/[email protected], npm/@wagmi/[email protected], npm/[email protected]

View full report↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.55 KB (-0.65% 🔽) 932 ms (-0.65% 🔽) 226 ms (+39.07% 🔺) 1.2 s
thirdweb (cjs) 122.35 KB (-1.05% 🔽) 2.5 s (-1.05% 🔽) 486 ms (-4.15% 🔽) 3 s
thirdweb (minimal + tree-shaking) 5.58 KB (-0.18% 🔽) 112 ms (-0.18% 🔽) 63 ms (+160.39% 🔺) 175 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 8 ms (+102.77% 🔺) 18 ms
thirdweb/react (minimal + tree-shaking) 19.27 KB (+1.01% 🔺) 386 ms (+1.01% 🔺) 77 ms (+95.31% 🔺) 462 ms

@jnsdls jnsdls force-pushed the 01-27-update_dependencies branch from e731ea6 to 9e29f69 Compare January 28, 2025 01:54
@jnsdls jnsdls force-pushed the 01-27-update_dependencies branch from 9e29f69 to 4fc7a9a Compare January 28, 2025 05:01
@jnsdls jnsdls force-pushed the 01-27-update_dependencies branch from 4fc7a9a to 800932f Compare January 28, 2025 05:10
@jnsdls jnsdls force-pushed the 01-27-update_dependencies branch from 800932f to 44dd968 Compare January 28, 2025 05:14
@codecov
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.81%. Comparing base (86f205e) to head (f2e6e94).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6079      +/-   ##
==========================================
+ Coverage   55.01%   56.81%   +1.79%     
==========================================
  Files        1152     1152              
  Lines       61280    63906    +2626     
  Branches     5186     5178       -8     
==========================================
+ Hits        33716    36311    +2595     
- Misses      26834    26865      +31     
  Partials      730      730              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 86f205e
packages 55.00% <ø> (+2.28%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...es/thirdweb/src/react/web/ui/prebuilt/NFT/utils.ts 100.00% <ø> (ø)

... and 624 files with indirect coverage changes

@jnsdls jnsdls merged commit 1616b7f into main Jan 28, 2025
32 checks passed
@jnsdls jnsdls deleted the 01-27-update_dependencies branch January 28, 2025 07:08
@joaquim-verges joaquim-verges mentioned this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. Ecosystem Portal Involves changes to the Ecosystem Portal packages Playground Changes involving the Playground codebase. Portal Involves changes to the Portal (docs) codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants