[Dashboard] Deploy config updates #6159
Merged
+77
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6159 +/- ##
=======================================
Coverage 56.81% 56.81%
=======================================
Files 1163 1163
Lines 64342 64342
Branches 5213 5213
=======================================
Hits 36556 36556
Misses 27057 27057
Partials 729 729
*This pull request uses carry forward flags. Click here to find out more. |
Contributor
size-limit report 📦
|
kumaryash90
added
the
DO NOT MERGE
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
apps/dashboard/src/components/contract-components/contract-deploy-form/custom-contract.tsx
Outdated
Show resolved
Hide resolved
kumaryash90
added
the
merge-queue
Member
Author
Merge activity
|
TOOL-3389
<!--
## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
## How to test
Unit tests, playground, etc.
-->
<!-- start pr-codex -->
---
## PR-Codex overview
This PR introduces a default fee configuration for contract deployments, updates the handling of platform fees, and improves the UI components related to fee management, ensuring that default values are used consistently throughout the application.
### Detailed summary
- Added `DEFAULT_FEE_RECIPIENT` and `DEFAULT_FEE_BPS` to `addresses.ts`.
- Introduced `hasDefaultFeeConfig` in `ContractSettingsPage`.
- Filtered out specific functions related to platform fees in `contract-function.tsx`.
- Integrated platform fee logic in `CustomContractForm`.
- Updated `PlatformFeeFieldset` to reflect marketplace conditions.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
graphite-app
bot
force-pushed
the
yash/deploy-config-updates
branch
from
bd2eede to
0c1bb6c
Compare
vercel
bot
temporarily deployed
to
Production – thirdweb_playground
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TOOL-3389
PR-Codex overview
This PR introduces a default fee configuration for contracts, modifies contract settings to accommodate this new fee structure, and enhances the user interface to reflect changes in platform fees.
Detailed summary
DEFAULT_FEE_RECIPIENTandDEFAULT_FEE_BPSinaddresses.ts.ContractSettingsPageto includehasDefaultFeeConfig.contract-function.tsxto exclude certain functions.getPlatformFeeInfoto determine fee configuration.CustomContractFormto use default fee values.PlatformFeeFieldsetto display fee information based on marketplace status.