Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Feb 7, 2025


PR-Codex overview

This PR focuses on adding fiat provider selection functionality to the PayEmbed component, enhancing the user experience when purchasing with fiat currencies.

Detailed summary

  • Added provider property in the quote interface.
  • Updated FiatProvider type to use FiatProviders array.
  • Introduced PREFERRED_FIAT_PROVIDER_STORAGE_KEY for local storage.
  • Created Providers component to select fiat providers.
  • Integrated provider selection in FiatScreenContent.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 9:25am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 9:25am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 9:25am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 9:25am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 9:25am

@changeset-bot
Copy link

changeset-bot bot commented Feb 7, 2025

🦋 Changeset detected

Latest commit: 66a472e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch
thirdweb-login Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joaquim-verges joaquim-verges marked this pull request as ready for review February 7, 2025 08:30
@joaquim-verges joaquim-verges requested review from a team as code owners February 7, 2025 08:30
@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Feb 7, 2025
Copy link
Member Author

joaquim-verges commented Feb 7, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.21 KB (0%) 925 ms (0%) 3.2 s (+42.45% 🔺) 4.2 s
thirdweb (cjs) 121.82 KB (0%) 2.5 s (0%) 6.3 s (+5.23% 🔺) 8.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 504 ms (+55.57% 🔺) 616 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 135 ms (+211.03% 🔺) 145 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 650 ms (-13.91% 🔽) 1.1 s

@joaquim-verges joaquim-verges force-pushed the _SDK_feat_Add_provider_selection_to_fiat_onramp branch from 77664f3 to 66a472e Compare February 7, 2025 09:22
@github-actions github-actions bot added the Playground Changes involving the Playground codebase. label Feb 7, 2025
@joaquim-verges joaquim-verges merged commit 2dfc245 into main Feb 7, 2025
29 of 31 checks passed
@joaquim-verges joaquim-verges deleted the _SDK_feat_Add_provider_selection_to_fiat_onramp branch February 7, 2025 09:41
@joaquim-verges joaquim-verges mentioned this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Playground Changes involving the Playground codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants