Skip to content

[Experiment] unstable_cache: Teams, Account, Projects, APIKey - DO NOT MERGE #6216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Experiment] unstable_cache: Teams, Account, Projects, APIKey - DO NOT MERGE #6216

wants to merge 1 commit into from

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Feb 9, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on enhancing caching mechanisms and improving account and team management functionalities by implementing unstable_cache and revalidateTag for various API calls, while also refactoring code for better readability and efficiency.

Detailed summary

  • Removed ensure-login route file.
  • Added caching functions in cacheTags.ts for accounts, teams, and projects.
  • Implemented unstable_cache in multiple API calls to cache responses.
  • Replaced direct API calls with cached versions in several actions and components.
  • Refactored getAuthToken usage to improve token handling.
  • Enhanced error handling for account verification processes.
  • Updated createTicketAction to use cached account data.
  • Added revalidateTag calls to ensure cache consistency after updates.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: cec80ac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 4:29pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 10, 2025 4:29pm
login ⬜️ Skipped (Inspect) Feb 10, 2025 4:29pm
thirdweb_playground ⬜️ Skipped (Inspect) Feb 10, 2025 4:29pm
wallet-ui ⬜️ Skipped (Inspect) Feb 10, 2025 4:29pm

@vercel vercel bot temporarily deployed to Preview – login February 9, 2025 22:40 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 9, 2025 22:40 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 9, 2025 22:40 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 9, 2025 22:40 Inactive
@MananTank MananTank marked this pull request as ready for review February 9, 2025 22:40
@MananTank MananTank requested review from a team as code owners February 9, 2025 22:40
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 9, 2025
@MananTank Graphite App
Copy link
Member Author

MananTank commented Feb 9, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank force-pushed the 02-10-_experiment_unstable_cache_teams_and_projects branch from b21d346 to 383de1a Compare February 9, 2025 22:41
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 9, 2025 22:41 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 9, 2025 22:41 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 9, 2025 22:41 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 9, 2025 22:41 Inactive
graphite-app[bot]
graphite-app bot reviewed Feb 9, 2025
View reviewed changes
@MananTank MananTank force-pushed the 02-10-_experiment_unstable_cache_teams_and_projects branch from 383de1a to e18fb36 Compare February 9, 2025 22:42
@MananTank MananTank changed the title [Experiment] unstable_cache: Teams and Projects [Experiment] unstable_cache: Teams and Projects - DO NOT MERGE Feb 9, 2025
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 9, 2025 22:42 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 9, 2025 22:42 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 9, 2025 22:42 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 9, 2025 22:42 Inactive
@codecov
Copy link

codecov bot commented Feb 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.72%. Comparing base (633f0ca) to head (cec80ac).
Report is 63 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6216   +/-   ##
=======================================
  Coverage   56.72%   56.72%           
=======================================
  Files        1161     1161           
  Lines       64289    64289           
  Branches     5196     5196           
=======================================
  Hits        36468    36468           
  Misses      27095    27095           
  Partials      726      726
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 633f0ca
packages 54.89% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.28 KB (0%) 926 ms (0%) 3.6 s (-0.56% 🔽) 4.5 s
thirdweb (cjs) 122.06 KB (0%) 2.5 s (0%) 7.2 s (+16.48% 🔺) 9.6 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 568 ms (-6.95% 🔽) 680 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 59 ms (+26.64% 🔺) 69 ms
thirdweb/react (minimal + tree-shaking) 19.3 KB (0%) 386 ms (0%) 540 ms (-10.13% 🔽) 926 ms

@MananTank MananTank force-pushed the 02-10-_experiment_unstable_cache_teams_and_projects branch from e18fb36 to 8856393 Compare February 9, 2025 22:47
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 9, 2025 22:47 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 9, 2025 22:47 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 9, 2025 22:47 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 10, 2025 15:00 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 10, 2025 15:00 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 10, 2025 15:00 Inactive
@MananTank MananTank force-pushed the 02-10-_experiment_unstable_cache_teams_and_projects branch from 4af57c6 to 684d12f Compare February 10, 2025 15:52
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 10, 2025 15:53 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 10, 2025 15:53 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 10, 2025 15:53 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 10, 2025 15:53 Inactive
@MananTank MananTank changed the title [Experiment] unstable_cache: Teams and Projects - DO NOT MERGE [Experiment] unstable_cache: Teams, Account, Projects, APIKey - DO NOT MERGE Feb 10, 2025
graphite-app[bot]
graphite-app bot reviewed Feb 10, 2025
View reviewed changes
@MananTank MananTank force-pushed the 02-10-_experiment_unstable_cache_teams_and_projects branch from 684d12f to 7a3916d Compare February 10, 2025 16:08
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 10, 2025 16:09 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 10, 2025 16:09 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 10, 2025 16:09 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 10, 2025 16:09 Inactive
@MananTank MananTank force-pushed the 02-10-_experiment_unstable_cache_teams_and_projects branch from 7a3916d to cec80ac Compare February 10, 2025 16:22
@vercel vercel bot temporarily deployed to Preview – login February 10, 2025 16:22 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 10, 2025 16:22 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 10, 2025 16:22 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 10, 2025 16:22 Inactive
@MananTank MananTank marked this pull request as ready for review February 10, 2025 16:55
@MananTank MananTank marked this pull request as draft February 10, 2025 16:55
@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2025

This PR has been inactive for 7 days. It is now marked as stale and will be closed in 2 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Feb 18, 2025
@github-actions github-actions bot closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

Assignees

@MananTank MananTank

Labels

Dashboard Involves changes to the Dashboard. Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MananTank