Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Feb 12, 2025


PR-Codex overview

This PR focuses on enhancing the user experience in the thirdweb application by improving error messaging and refining the UI components related to wallet selection and token balance display.

Detailed summary

  • Updated getErrorMessage function to return specific error messages for low purchase amounts.
  • Introduced filteredWallets to streamline wallet display logic in PaymentSelectionScreen.tsx.
  • Added a message for insufficient funds in connected wallets.
  • Refined UI layout for wallet and token balance display.
  • Replaced formatTokenBalance with FiatValue for better balance representation.
  • Adjusted button styles for improved aesthetics and functionality.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Feb 12, 2025

🦋 Changeset detected

Latest commit: 72eae54

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch
thirdweb-login Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 9:39am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 9:39am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 9:39am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 9:39am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 9:39am

@joaquim-verges joaquim-verges marked this pull request as ready for review February 12, 2025 09:25
@joaquim-verges joaquim-verges requested review from a team as code owners February 12, 2025 09:25
@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Feb 12, 2025
Copy link
Member Author

joaquim-verges commented Feb 12, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 235 ms (+59.28% 🔺) 1.2 s
thirdweb (cjs) 121.89 KB (0%) 2.5 s (0%) 521 ms (+8.87% 🔺) 3 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 111 ms (+191.33% 🔺) 223 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 11 ms (+163.08% 🔺) 21 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 128 ms (+223.84% 🔺) 514 ms

@joaquim-verges joaquim-verges merged commit fbafb65 into main Feb 12, 2025
26 of 34 checks passed
@joaquim-verges joaquim-verges deleted the _SDK_fix_Polish_PayEmbed_UI_and_balance_display branch February 12, 2025 09:30
@joaquim-verges joaquim-verges mentioned this pull request Feb 12, 2025
@codecov
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 3.44828% with 56 lines in your changes missing coverage. Please review.

Project coverage is 56.88%. Comparing base (159ffbf) to head (72eae54).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...ConnectWallet/screens/Buy/WalletSelectorButton.tsx 7.40% 25 Missing ⚠️
...Wallet/screens/Buy/swap/PaymentSelectionScreen.tsx 0.00% 25 Missing ⚠️
packages/thirdweb/src/react/web/utils/errors.ts 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6237      +/-   ##
==========================================
- Coverage   56.90%   56.88%   -0.03%     
==========================================
  Files        1166     1166              
  Lines       64475    64507      +32     
  Branches     5224     5221       -3     
==========================================
+ Hits        36692    36693       +1     
- Misses      27056    27086      +30     
- Partials      727      728       +1     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 159ffbf
packages 55.09% <3.44%> (-0.04%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
packages/thirdweb/src/react/web/utils/errors.ts 13.33% <0.00%> (-6.67%) ⬇️
...ConnectWallet/screens/Buy/WalletSelectorButton.tsx 11.72% <7.40%> (+0.11%) ⬆️
...Wallet/screens/Buy/swap/PaymentSelectionScreen.tsx 9.79% <0.00%> (-0.54%) ⬇️

... and 5 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants