Skip to content

[thirdweb] feat: Replace walletClient with wallet in viemAdapter #6282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2025
Merged

[thirdweb] feat: Replace walletClient with wallet in viemAdapter #6282

merged 1 commit into from
Feb 18, 2025

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Feb 18, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on deprecating the viemAdapter.walletClient in favor of viemAdapter.wallet, which allows for better management of wallet instances instead of accounts. This change enhances wallet lifecycle management, including chain switching and event handling.

Detailed summary

  • Updated comments and variable names to reflect the transition from walletClient to wallet.
  • Deprecated viemAdapter.walletClient methods, replacing them with viemAdapter.wallet.
  • Modified test files to use the new wallet instance methods.
  • Enhanced functionality for switching chains and managing wallet lifecycle.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Feb 18, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 0:37am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 0:37am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 0:37am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 0:37am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 0:37am

@changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2025

🦋 Changeset detected

Latest commit: fbda883

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch
thirdweb-login Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added Portal Involves changes to the Portal (docs) codebase. packages SDK Involves changes to the thirdweb SDK labels Feb 18, 2025
@joaquim-verges joaquim-verges marked this pull request as ready for review February 18, 2025 00:28
@joaquim-verges joaquim-verges requested review from a team as code owners February 18, 2025 00:28
@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Feb 18, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 270 ms (+26.18% 🔺) 1.2 s
thirdweb (cjs) 121.89 KB (0%) 2.5 s (0%) 530 ms (+23.12% 🔺) 3 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 188 ms (+782.82% 🔺) 300 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 59 ms (+376.73% 🔺) 69 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 63 ms (-11.21% 🔽) 449 ms

@codecov
Copy link

codecov bot commented Feb 18, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.93750% with 25 lines in your changes missing coverage. Please review.

Project coverage is 56.88%. Comparing base (b182302) to head (fbda883).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/thirdweb/src/adapters/viem.ts 60.93% 25 Missing ⚠️

❌ Your patch status has failed because the patch coverage (60.93%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6282      +/-   ##
==========================================
+ Coverage   56.85%   56.88%   +0.02%     
==========================================
  Files        1168     1168              
  Lines       64677    64741      +64     
  Branches     5246     5257      +11     
==========================================
+ Hits        36772    36825      +53     
- Misses      27177    27188      +11     
  Partials      728      728
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from b182302
packages 55.10% <60.93%> (+0.03%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
packages/thirdweb/src/adapters/viem.ts 50.64% <60.93%> (+3.89%) ⬆️

... and 3 files with indirect coverage changes

@joaquim-verges joaquim-verges merged commit 45ca033 into main Feb 18, 2025
34 of 38 checks passed
@joaquim-verges joaquim-verges deleted the _thirdweb_feat_Replace_walletClient_with_wallet_in_viemAdapter branch February 18, 2025 00:41
@joaquim-verges joaquim-verges mentioned this pull request Feb 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joaquim-verges joaquim-verges

Labels

packages Portal Involves changes to the Portal (docs) codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joaquim-verges