Skip to content

[Docs] Improve Unity Build Instructions #6287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2025
Merged

[Docs] Improve Unity Build Instructions #6287

merged 1 commit into from
Feb 19, 2025

Conversation

@0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Feb 18, 2025 •
edited by pr-codex bot
Loading

Closes TOOL-3456

PR-Codex overview

This PR focuses on correcting a typo in the blockchain-api documentation and enhancing the unity build instructions by clarifying sections, improving descriptions, and adding troubleshooting guidance for OAuth redirects.

Detailed summary

  • Corrected the typo in the description for the blockchain-api.
  • Changed section title from General to All Target Platforms in build-instructions.
  • Specified IL2CPP Code Generation in the Build Settings.
  • Clarified the Redirect Schemes section with additional context for OAuth redirects.
  • Added a new section on Troubleshooting OAuth Redirects with best practices and requirements for bundle IDs.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@0xFirekeeper 0xFirekeeper added merge-queue Adds the pull request to Graphite's merge queue. Portal Involves changes to the Portal (docs) codebase. labels Feb 18, 2025
@0xFirekeeper 0xFirekeeper requested review from a team as code owners February 18, 2025 17:44
@linear
Copy link

linear bot commented Feb 18, 2025

TOOL-3456 Improve Build Instructions

@changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 45ac0cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 18, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 8:02am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
login ⬜️ Skipped (Inspect) Feb 19, 2025 8:02am
thirdweb_playground ⬜️ Skipped (Inspect) Feb 19, 2025 8:02am
thirdweb-www ⬜️ Skipped (Inspect) Feb 19, 2025 8:02am
wallet-ui ⬜️ Skipped (Inspect) Feb 19, 2025 8:02am

@0xFirekeeper Graphite App
Copy link
Member Author

0xFirekeeper commented Feb 18, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Feb 18, 12:44 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 19, 2:55 AM EST: A user added this pull request to the Graphite merge queue.
  • Feb 19, 3:03 AM EST: A user merged this pull request with the Graphite merge queue.

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 18, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 2.3 s (+43.84% 🔺) 3.3 s
thirdweb (cjs) 121.89 KB (0%) 2.5 s (0%) 4.8 s (-19.99% 🔽) 7.2 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 236 ms (+3.01% 🔺) 348 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 296 ms (+421.49% 🔺) 306 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 527 ms (+64.04% 🔺) 913 ms

@codecov
Copy link

codecov bot commented Feb 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.83%. Comparing base (8610b46) to head (45ac0cb).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6287   +/-   ##
=======================================
  Coverage   56.83%   56.83%           
=======================================
  Files        1168     1168           
  Lines       64793    64793           
  Branches     5260     5260           
=======================================
  Hits        36824    36824           
  Misses      27242    27242           
  Partials      727      727
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 8610b46
packages 55.04% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@vercel vercel bot temporarily deployed to Preview – thirdweb-www February 18, 2025 17:56 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 18, 2025 17:56 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 18, 2025 17:56 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 18, 2025 17:56 Inactive
@0xFirekeeper
[Docs] Improve Unity Build Instructions (#6287)
45ac0cb 
Closes TOOL-3456

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating descriptions and improving the clarity of build instructions for Unity and troubleshooting OAuth redirects.

### Detailed summary
- Fixed a typo in the `description` for the Unreal Engine link.
- Changed section title from `General` to `All Target Platforms`.
- Clarified build settings for IL2CPP Code Generation.
- Added details about OAuth redirect troubleshooting, including best practices for bundle IDs.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the firekeeper/build-docs-update branch from dba4dea to 45ac0cb Compare February 19, 2025 07:56
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 19, 2025 07:56 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 19, 2025 07:56 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www February 19, 2025 07:56 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 19, 2025 07:56 Inactive
@graphite-app graphite-app bot merged commit 45ac0cb into main Feb 19, 2025
33 checks passed
@graphite-app graphite-app bot deleted the firekeeper/build-docs-update branch February 19, 2025 08:03
@vercel vercel bot temporarily deployed to Production – wallet-ui February 19, 2025 08:03 Inactive
@vercel vercel bot temporarily deployed to Production – login February 19, 2025 08:03 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www February 19, 2025 08:03 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground February 19, 2025 08:03 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquim-verges joaquim-verges joaquim-verges approved these changes

Assignees

@0xFirekeeper 0xFirekeeper

Labels

merge-queue Adds the pull request to Graphite's merge queue. Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@0xFirekeeper @joaquim-verges