Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Feb 19, 2025

PR-Codex overview

This PR focuses on adding img elements for network logos in various components while ensuring compliance with ESLint rules related to using img tags in Next.js.

Detailed summary

  • In erc1155-mint-to.tsx, added an img tag for NFT preview with ESLint comment.
  • In TransactionResults.tsx, added img tags for network logos (BaseSep, OP, Ethereum) with ESLint comments for each.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Feb 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 6:48pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 19, 2025 6:48pm
login ⬜️ Skipped (Inspect) Feb 19, 2025 6:48pm
thirdweb-www ⬜️ Skipped (Inspect) Feb 19, 2025 6:48pm
wallet-ui ⬜️ Skipped (Inspect) Feb 19, 2025 6:48pm

@linear
Copy link

linear bot commented Feb 19, 2025

@vercel vercel bot temporarily deployed to Preview – login February 19, 2025 12:35 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 19, 2025 12:35 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www February 19, 2025 12:35 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 19, 2025 12:35 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Feb 19, 2025

⚠️ No Changeset found

Latest commit: c30b6d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Playground Changes involving the Playground codebase. label Feb 19, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review February 19, 2025 12:36
@MananTank MananTank requested review from a team as code owners February 19, 2025 12:36
@codecov
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.83%. Comparing base (45ac0cb) to head (c30b6d7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6297   +/-   ##
=======================================
  Coverage   56.83%   56.83%           
=======================================
  Files        1168     1168           
  Lines       64793    64793           
  Branches     5260     5260           
=======================================
  Hits        36824    36824           
  Misses      27242    27242           
  Partials      727      727           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 45ac0cb
packages 55.04% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 633 ms (+18.17% 🔺) 1.6 s
thirdweb (cjs) 121.89 KB (0%) 2.5 s (0%) 1.3 s (+8.24% 🔺) 3.7 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 71 ms (-10.58% 🔽) 183 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 37 ms (+100.81% 🔺) 47 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 101 ms (-23.21% 🔽) 486 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 19, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 02-19-_tool-3470_playground_fix_eslint_image_warnings branch from 8e45791 to c30b6d7 Compare February 19, 2025 18:47
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 19, 2025 18:47 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 19, 2025 18:47 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 19, 2025 18:47 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www February 19, 2025 18:47 Inactive
@graphite-app graphite-app bot merged commit c30b6d7 into main Feb 19, 2025
32 checks passed
@graphite-app graphite-app bot deleted the 02-19-_tool-3470_playground_fix_eslint_image_warnings branch February 19, 2025 18:50
@vercel vercel bot temporarily deployed to Production – login February 19, 2025 18:50 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui February 19, 2025 18:50 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www February 19, 2025 18:50 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Playground Changes involving the Playground codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants