Skip to content

[TOOL-3496] Dashboard: Ecosystem pages UI improvements #6311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2025
Merged

[TOOL-3496] Dashboard: Ecosystem pages UI improvements #6311

merged 1 commit into from
Feb 22, 2025

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Feb 21, 2025 •
edited by pr-codex bot
Loading

image.png

image.png

image.png

PR-Codex overview

This PR focuses on refactoring the loading components and improving the ecosystem creation process in the application. It enhances the structure of several components, introduces new imports, and modifies layout and styling for better usability and maintainability.

Detailed summary

  • Deleted unused files: error.ts, fetch-api-server.ts, layout.tsx, page.tsx.
  • Updated Loading components to import and use GenericLoadingPage.
  • Modified GenericLoadingPage to accept a className prop and use cn for class management.
  • Refactored EcosystemCreatePage to simplify layout and structure.
  • Enhanced EcosystemAnalyticsPage to fetch and display wallet usage statistics.
  • Replaced direct API calls with fetchEcosystem in the Page component.
  • Updated EcosystemLayoutSlug to handle authentication with getAuthToken.
  • Refined EcosystemHeader to improve the display of ecosystem information.
  • Improved styling and structure in various components for better UX.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Feb 21, 2025

TOOL-3496 Ecosystem pages UI improvements

@vercel
Copy link

vercel bot commented Feb 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2025 1:45am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 22, 2025 1:45am
login ⬜️ Skipped (Inspect) Feb 22, 2025 1:45am
thirdweb_playground ⬜️ Skipped (Inspect) Feb 22, 2025 1:45am
wallet-ui ⬜️ Skipped (Inspect) Feb 22, 2025 1:45am

@changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 514c1a8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MananTank MananTank marked this pull request as ready for review February 21, 2025 20:16
@MananTank MananTank requested review from a team as code owners February 21, 2025 20:16
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 21, 2025
@MananTank Graphite App
Copy link
Member Author

MananTank commented Feb 21, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Feb 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.83%. Comparing base (a2d75df) to head (514c1a8).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6311   +/-   ##
=======================================
  Coverage   56.83%   56.83%           
=======================================
  Files        1168     1168           
  Lines       64793    64793           
  Branches     5258     5258           
=======================================
  Hits        36824    36824           
  Misses      27242    27242           
  Partials      727      727
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from a2d75df
packages 55.04% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 100 ms (+131.58% 🔺) 1.1 s
thirdweb (cjs) 121.89 KB (0%) 2.5 s (0%) 148 ms (+17.97% 🔺) 2.6 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 61 ms (+660.93% 🔺) 173 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 23 ms (+1119.15% 🔺) 33 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 63 ms (+346.02% 🔺) 449 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 22, 2025 •
edited
Loading

Merge activity

@MananTank
[TOOL-3496] Dashboard: Ecosystem pages UI improvements (#6311)
514c1a8 
![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/yNOf1svJ8o3zjO7zQouZ/f1d0c79f-f711-42e3-9c5e-2b57bfacc05b.png)

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/yNOf1svJ8o3zjO7zQouZ/39702f47-477c-4177-bf3b-ac41c05b5093.png)

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/yNOf1svJ8o3zjO7zQouZ/ce5cc358-a16a-4a06-90a1-a11ff47f67e4.png)

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on refactoring and enhancing the loading components and ecosystem management pages in the `dashboard` application. It introduces improvements in code structure, UI components, and error handling.

### Detailed summary
- Removed unused files from `utils`, `data`, and `ecosystem` directories.
- Updated `GenericLoadingPage` to accept a `className` prop for styling.
- Refactored loading components to use the new `GenericLoadingPage` structure.
- Enhanced `EcosystemCreatePage` layout and styling.
- Improved `EcosystemAnalyticsPage` to fetch and display wallet usage statistics.
- Replaced direct API calls with token-based authentication in ecosystem pages.
- Updated `EcosystemHeader` to utilize new UI components and improve layout.
- Refactored ecosystem creation form for better user experience and error handling.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 22, 2025 01:38 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 22, 2025 01:38 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 22, 2025 01:38 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 22, 2025 01:38 Inactive
@graphite-app graphite-app bot merged commit 514c1a8 into main Feb 22, 2025
33 checks passed
@graphite-app graphite-app bot deleted the tool-3496 branch February 22, 2025 01:46
@vercel vercel bot temporarily deployed to Production – thirdweb_playground February 22, 2025 01:46 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui February 22, 2025 01:46 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 February 22, 2025 01:46 Inactive
@vercel vercel bot temporarily deployed to Production – login February 22, 2025 01:46 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@jnsdls jnsdls jnsdls approved these changes

Assignees

@MananTank MananTank

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls