Skip to content

enable team invites for starter and growth plans #6312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2025
Merged

enable team invites for starter and growth plans #6312

merged 1 commit into from
Feb 21, 2025

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Feb 21, 2025 •
edited by pr-codex bot
Loading

blocked by: https://github.com/thirdweb-dev/api-server/pull/1412

PR-Codex overview

This PR updates the InviteSection component to modify the logic for enabling invites based on the team plan and user permissions, and it also refines the messaging displayed to users regarding team invites.

Detailed summary

  • Changed inviteEnabled logic to allow invites if the team plan is not "free" and the user has edit permission.
  • Updated user messaging to clarify that team members are billed according to the plan instead of stating invites are not enabled.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Feb 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2025 11:46pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 21, 2025 11:46pm
login ⬜️ Skipped (Inspect) Feb 21, 2025 11:46pm
thirdweb_playground ⬜️ Skipped (Inspect) Feb 21, 2025 11:46pm
wallet-ui ⬜️ Skipped (Inspect) Feb 21, 2025 11:46pm

@changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: cc5cdd4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jnsdls jnsdls added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Feb 21, 2025 — with Graphite App
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 21, 2025
@jnsdls Graphite App
Copy link
Member Author

jnsdls commented Feb 21, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls marked this pull request as ready for review February 21, 2025 21:33
@jnsdls jnsdls requested review from a team as code owners February 21, 2025 21:33
@codecov
Copy link

codecov bot commented Feb 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.83%. Comparing base (8823acb) to head (cc5cdd4).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6312   +/-   ##
=======================================
  Coverage   56.83%   56.83%           
=======================================
  Files        1168     1168           
  Lines       64793    64793           
  Branches     5258     5258           
=======================================
  Hits        36824    36824           
  Misses      27242    27242           
  Partials      727      727
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 8823acb
packages 55.04% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 2.6 s (+62.47% 🔺) 3.6 s
thirdweb (cjs) 121.89 KB (0%) 2.5 s (0%) 3.6 s (-20.32% 🔽) 6.1 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 235 ms (+29.99% 🔺) 347 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 52 ms (+74.12% 🔺) 62 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 502 ms (+18.16% 🔺) 887 ms

@jnsdls jnsdls removed the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Feb 21, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 21, 2025 •
edited
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the enable_team_invites_for_starter_and_growth_plans branch from 1507ea6 to cc5cdd4 Compare February 21, 2025 23:43
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 21, 2025 23:43 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 21, 2025 23:43 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 21, 2025 23:43 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 21, 2025 23:43 Inactive
@graphite-app graphite-app bot merged commit cc5cdd4 into main Feb 21, 2025
32 of 33 checks passed
@graphite-app graphite-app bot deleted the enable_team_invites_for_starter_and_growth_plans branch February 21, 2025 23:46
@vercel vercel bot temporarily deployed to Production – docs-v2 February 21, 2025 23:46 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground February 21, 2025 23:46 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui February 21, 2025 23:46 Inactive
@vercel vercel bot temporarily deployed to Production – login February 21, 2025 23:46 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MananTank MananTank MananTank approved these changes

Assignees

@jnsdls jnsdls

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jnsdls @MananTank