Skip to content

only validate Turnstile captcha on Vercel environments #6314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2025
Merged

only validate Turnstile captcha on Vercel environments #6314

merged 1 commit into from
Feb 22, 2025
+73 −66

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Feb 22, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR introduces a utility function isVercel to check if the application is running in a Vercel environment. It refactors the login handling process to conditionally validate a Turnstile token based on the environment, streamlining error handling and improving code readability.

Detailed summary

  • Added isVercel function to check Vercel environment.
  • Refactored getVercelEnv to use isVercel.
  • Updated login process to validate Turnstile token only in Vercel environment.
  • Improved error handling for IP address retrieval.
  • Enhanced readability of the code structure.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Feb 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2025 0:19am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 22, 2025 0:19am
login ⬜️ Skipped (Inspect) Feb 22, 2025 0:19am
thirdweb_playground ⬜️ Skipped (Inspect) Feb 22, 2025 0:19am
wallet-ui ⬜️ Skipped (Inspect) Feb 22, 2025 0:19am

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 22, 2025 00:09 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 22, 2025 00:09 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 22, 2025 00:09 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 22, 2025 00:09 Inactive
@jnsdls jnsdls marked this pull request as ready for review February 22, 2025 00:09
@jnsdls jnsdls requested review from a team as code owners February 22, 2025 00:09
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 22, 2025
@jnsdls Graphite App
Copy link
Member Author

jnsdls commented Feb 22, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Feb 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.83%. Comparing base (cc5cdd4) to head (43638e5).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6314   +/-   ##
=======================================
  Coverage   56.83%   56.83%           
=======================================
  Files        1168     1168           
  Lines       64793    64793           
  Branches     5258     5258           
=======================================
  Hits        36824    36824           
  Misses      27242    27242           
  Partials      727      727
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from cc5cdd4
packages 55.04% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 22, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 2.6 s (+26.69% 🔺) 3.5 s
thirdweb (cjs) 121.89 KB (0%) 2.5 s (0%) 5.3 s (+7.74% 🔺) 7.7 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 190 ms (-21.88% 🔽) 302 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 171 ms (-21.99% 🔽) 181 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 1.2 s (+177.75% 🔺) 1.6 s

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 22, 2025 •
edited
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the only_validate_Turnstile_captcha_on_Vercel_environments branch from 3f99ca2 to 43638e5 Compare February 22, 2025 00:16
@changeset-bot
Copy link

changeset-bot bot commented Feb 22, 2025

⚠️ No Changeset found

Latest commit: 43638e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 February 22, 2025 00:16 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 22, 2025 00:16 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 22, 2025 00:16 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 22, 2025 00:16 Inactive
@graphite-app graphite-app bot merged commit 43638e5 into main Feb 22, 2025
32 of 33 checks passed
@graphite-app graphite-app bot deleted the only_validate_Turnstile_captcha_on_Vercel_environments branch February 22, 2025 00:19
@vercel vercel bot temporarily deployed to Production – docs-v2 February 22, 2025 00:19 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui February 22, 2025 00:19 Inactive
@vercel vercel bot temporarily deployed to Production – login February 22, 2025 00:19 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground February 22, 2025 00:19 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MananTank MananTank MananTank approved these changes

Assignees

@jnsdls jnsdls

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jnsdls @MananTank